G915-2-Data-Modeling-381 / Midterm-Group-Project

0 stars 0 forks source link

Constructive Feedback Log - Adrian #6

Closed ambergarcia closed 2 years ago

ambergarcia commented 2 years ago

Instructions

Provide constructive feedback to the following members:

[x] Amber
[x] Jasminder
[ ] Oliver
[ ] Wade

Please provide at least one; Positive & Negative feedback or a feature to implement that you like.

Store your feedback here as a comment, and close your issue when complete.

adrianmnh commented 2 years ago

Peer Review

`Jasminder Garcha`

Great use of the color schemes for the different types of entities. Your validation rules and defaults are thorough.

A few errors when forward engineering but here's how to fix.

on the Production.Product View, uncheck the user defined SQL (1 instance)
the automated triggers use the table names in the sql. The problem is the table "Order" because order is also a keyword. Change the Order table to Orders, or change the triggers and wrap the word order in brackets (10 instances)

[ ] CDM and LDM
[x] Validation Rules
[x] Default values forattributes
[x] Data Domains and subdomains

`Amber Garcia`

Overall excellent work, great addition of theme to your Model, I was able to forward engineer it without any errors.

[ ] CDM and LDM
[x] Validation Rules
[x] Default values forattributes
[x] Data Domains and subdomains