GA-MO / react-confirm-alert

react component confirm dialog.
https://ga-mo.github.io/react-confirm-alert/demo/
MIT License
271 stars 105 forks source link

Custom divTarget react-confirm-alert id location bug #45

Closed tahv0 closed 2 years ago

tahv0 commented 4 years ago

If one manually adds react-confirm-alert id to some other location of choice, the lib still writes something to body rootwith id react-confirm-alert-firm-svg.

I think that divTarget should be documented or even be optional prop that can be given.

If react-confirm-alert prop is given or manually set, react-confirm-alert-firm-svg should also use same location in DOM.

Workaround to fix this bug:

tahv0 commented 4 years ago

It turns out that my workaround above won't work because there is this body class react-confirm-alert-body-element which location can not be changed same way.

GA-MO commented 2 years ago

This feature is in Version 3.0.0