GA-MO / react-confirm-alert

react component confirm dialog.
https://ga-mo.github.io/react-confirm-alert/demo/
MIT License
271 stars 105 forks source link

ESLint: Declare only one React component per file(react/no-multi-comp) #67

Open mdodge-ecgrow opened 3 years ago

mdodge-ecgrow commented 3 years ago

I am using this library throughout my application. It works beautifully! But I keep getting these ESLint errors when I use it. The two errors I usually get are: ESLint: Declare only one React component per file(react/no-multi-comp) and ESLint: Component definition is missing display name(react/display-name).

And here is an example of the code that is throwing those two errors (this is a function inside one of my components):

const deleteComment = (id) => {
    confirmAlert({
        customUI: ({ onClose }) => {
            return (
                <div className={'custom-ui-dialog'}>
                    <h1>Confirm Remove Comment</h1>
                    <div className={'body'}>
                        <h3>Are you sure you want to remove this comment?</h3>
                        <div className={'buttons'}>
                            <button onClick={onClose}>No</button>
                            <button
                                onClick={() => {
                                    deleteCommentAPI(id).then(() => {
                                        onClose();
                                    });
                                }}
                            >
                                Yes
                            </button>
                        </div>
                    </div>
                </div>
            );
        },
        closeOnEscape: false,
        closeOnClickOutside: false,
    });
};

The error shows specifically on this line: customUI: ({ onClose }) => {.

While it does not appear to be causing any real issues, I would love to be able to clean up those errors and get this fixed.