search

GAA-UAM / scikit-fda

Functional Data Analysis Python package
https://fda.readthedocs.io
BSD 3-Clause "New" or "Revised" License
290 stars 51 forks source link

Score functions for FData #429

Closed ElenaPetrunina closed 1 year ago

ElenaPetrunina commented 2 years ago

Close #378

codecov[bot] commented 2 years ago

Codecov Report

Base: 84.96% // Head: 85.28% // Increases project coverage by +0.31% :tada:

Coverage data is based on head (1ff0bff) compared to base (46fc684). Patch coverage: 94.91% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #429 +/- ## =========================================== + Coverage 84.96% 85.28% +0.31% =========================================== Files 135 137 +2 Lines 10731 11043 +312 =========================================== + Hits 9118 9418 +300 - Misses 1613 1625 +12 ``` | [Impacted Files](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM) | Coverage Δ | | |---|---|---| | [skfda/ml/\_neighbors\_base.py](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/429/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvbWwvX25laWdoYm9yc19iYXNlLnB5) | `91.33% <ø> (-1.49%)` | :arrow_down: | | [skfda/representation/interpolation.py](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/429/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvcmVwcmVzZW50YXRpb24vaW50ZXJwb2xhdGlvbi5weQ==) | `84.37% <ø> (ø)` | | | [skfda/misc/scoring.py](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/429/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvbWlzYy9zY29yaW5nLnB5) | `91.50% <91.50%> (ø)` | | | [skfda/\_utils/\_sklearn\_adapter.py](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/429/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvX3V0aWxzL19za2xlYXJuX2FkYXB0ZXIucHk=) | `81.96% <100.00%> (+0.61%)` | :arrow_up: | | [skfda/exploratory/stats/\_stats.py](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/429/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvZXhwbG9yYXRvcnkvc3RhdHMvX3N0YXRzLnB5) | `86.36% <100.00%> (+2.23%)` | :arrow_up: | | [skfda/representation/grid.py](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/429/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvcmVwcmVzZW50YXRpb24vZ3JpZC5weQ==) | `86.53% <100.00%> (+0.86%)` | :arrow_up: | | [skfda/tests/test\_neighbors.py](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/429/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvdGVzdHMvdGVzdF9uZWlnaGJvcnMucHk=) | `99.48% <100.00%> (-0.02%)` | :arrow_down: | | [skfda/tests/test\_scoring.py](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/429/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvdGVzdHMvdGVzdF9zY29yaW5nLnB5) | `100.00% <100.00%> (ø)` | | | [skfda/representation/\_functional\_data.py](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/429/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvcmVwcmVzZW50YXRpb24vX2Z1bmN0aW9uYWxfZGF0YS5weQ==) | `84.41% <0.00%> (+0.56%)` | :arrow_up: | | ... and [1 more](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/429/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

vnmabus commented 2 years ago

It appears that the topic of constant predictions has been already discussed in scikit-learn: https://github.com/scikit-learn/scikit-learn/issues/16857

We should probably try to adapt the same solution as them, either in this PR or in a future fix before the next release: https://github.com/scikit-learn/scikit-learn/pull/17266