GAA-UAM / scikit-fda

Functional Data Analysis Python package
https://fda.readthedocs.io
BSD 3-Clause "New" or "Revised" License
309 stars 58 forks source link

Fix wrong variable name in fpca #478

Closed Ddelval closed 2 years ago

Ddelval commented 2 years ago

The underscore at the end of the variable name was lost in refactoring in a previous commit.

codecov[bot] commented 2 years ago

Codecov Report

Base: 84.96% // Head: 84.96% // No change to project coverage :thumbsup:

Coverage data is based on head (4f07cdb) compared to base (41f9f53). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #478 +/- ## ======================================== Coverage 84.96% 84.96% ======================================== Files 135 135 Lines 10731 10731 ======================================== Hits 9118 9118 Misses 1613 1613 ``` | [Impacted Files](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/478?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM) | Coverage Δ | | |---|---|---| | [skfda/preprocessing/dim\_reduction/\_fpca.py](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/478/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvcHJlcHJvY2Vzc2luZy9kaW1fcmVkdWN0aW9uL19mcGNhLnB5) | `91.20% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.