search

GAA-UAM / scikit-fda

Functional Data Analysis Python package
https://fda.readthedocs.io
BSD 3-Clause "New" or "Revised" License
287 stars 51 forks source link

Make weights parameter private #483

Closed Ddelval closed 1 year ago

Ddelval commented 1 year ago

Choosing the weights for the numerical quadrature used during the calculation of FPCA does not seem like a parameter that the end user should need to tweak. Therefore, it has been removed from the documentation, and its name in the constructor has been prepended with an underscore to indicate that it is a private parameter now

codecov[bot] commented 1 year ago

Codecov Report

Base: 85.28% // Head: 85.28% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (6215705) compared to base (099560f). Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #483 +/- ## =========================================== - Coverage 85.28% 85.28% -0.01% =========================================== Files 137 137 Lines 11043 11040 -3 =========================================== - Hits 9418 9415 -3 Misses 1625 1625 ``` | [Impacted Files](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/483?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM) | Coverage Δ | | |---|---|---| | [skfda/preprocessing/dim\_reduction/\_fpca.py](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvcHJlcHJvY2Vzc2luZy9kaW1fcmVkdWN0aW9uL19mcGNhLnB5) | `90.98% <66.66%> (-0.22%)` | :arrow_down: | | [skfda/tests/test\_fpca.py](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvdGVzdHMvdGVzdF9mcGNhLnB5) | `99.30% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.