Closed Ddelval closed 1 year ago
Base: 85.28% // Head: 85.28% // No change to project coverage :thumbsup:
Coverage data is based on head (
e22beeb
) compared to base (e22beeb
). Patch has no changes to coverable lines.:exclamation: Current head e22beeb differs from pull request most recent head 168dac6. Consider uploading reports for the commit 168dac6 to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Compare the functions obtained with the
inverse_transform
instead of the scores obtained intransform
directly. In doing so, we can use a smaller tolerance (0.25 before vs 0.1 now).There are two things to keep in mind:
fit
andtransform
because fda.usc uses different quadratures for these two operations.inverse_transform
with coefficients obtained from fda.usc is not strictly correct since the principal components calculated in fda.usc are slightly different. However, the result is very similar, and this difference is not the cause of still having to use a high tolerance (0.1).