GAA-UAM / scikit-fda

Functional Data Analysis Python package
https://fda.readthedocs.io
BSD 3-Clause "New" or "Revised" License
287 stars 51 forks source link

Use inverse transform when comparing scores in fpca tests #484

Closed Ddelval closed 1 year ago

Ddelval commented 1 year ago

Compare the functions obtained with the inverse_transform instead of the scores obtained in transform directly. In doing so, we can use a smaller tolerance (0.25 before vs 0.1 now).

There are two things to keep in mind:

codecov[bot] commented 1 year ago

Codecov Report

Base: 85.28% // Head: 85.28% // No change to project coverage :thumbsup:

Coverage data is based on head (e22beeb) compared to base (e22beeb). Patch has no changes to coverable lines.

:exclamation: Current head e22beeb differs from pull request most recent head 168dac6. Consider uploading reports for the commit 168dac6 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #484 +/- ## ======================================== Coverage 85.28% 85.28% ======================================== Files 137 137 Lines 11040 11040 ======================================== Hits 9415 9415 Misses 1625 1625 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.