GAA-UAM / scikit-fda

Functional Data Analysis Python package
https://fda.readthedocs.io
BSD 3-Clause "New" or "Revised" License
287 stars 51 forks source link

Issue/classifier classes/qda #494

Closed m5signorini closed 1 year ago

m5signorini commented 1 year ago

Quadratic discriminant analysis fixes according to issue #480.

codecov[bot] commented 1 year ago

Codecov Report

Base: 85.35% // Head: 85.35% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (f40872f) compared to base (fca9f31). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #494 +/- ## ======================================== Coverage 85.35% 85.35% ======================================== Files 139 139 Lines 11063 11064 +1 ======================================== + Hits 9443 9444 +1 Misses 1620 1620 ``` | [Impacted Files](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM) | Coverage Δ | | |---|---|---| | [skfda/ml/classification/\_qda.py](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/494/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvbWwvY2xhc3NpZmljYXRpb24vX3FkYS5weQ==) | `100.00% <100.00%> (ø)` | | | [skfda/tests/test\_classifier\_classes.py](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/494/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvdGVzdHMvdGVzdF9jbGFzc2lmaWVyX2NsYXNzZXMucHk=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

m5signorini commented 1 year ago

I included a fixed random_state for the test_classifier_classes in this same pull request.