GAA-UAM / scikit-fda

Functional Data Analysis Python package
https://fda.readthedocs.io
BSD 3-Clause "New" or "Revised" License
309 stars 58 forks source link

Custom Basis #495

Closed Ddelval closed 1 year ago

Ddelval commented 2 years ago

The CustomBasis class provides the functionality required to create a basis from arbitrary functions.

codecov[bot] commented 2 years ago

Codecov Report

Base: 85.41% // Head: 85.52% // Increases project coverage by +0.10% :tada:

Coverage data is based on head (9d933f1) compared to base (864f830). Patch coverage: 92.09% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #495 +/- ## =========================================== + Coverage 85.41% 85.52% +0.10% =========================================== Files 139 141 +2 Lines 11103 11277 +174 =========================================== + Hits 9484 9645 +161 - Misses 1619 1632 +13 ``` | [Impacted Files](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM) | Coverage Δ | | |---|---|---| | [skfda/representation/\_functional\_data.py](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/495/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvcmVwcmVzZW50YXRpb24vX2Z1bmN0aW9uYWxfZGF0YS5weQ==) | `83.56% <66.66%> (-0.29%)` | :arrow_down: | | [skfda/representation/basis/\_custom\_basis.py](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/495/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvcmVwcmVzZW50YXRpb24vYmFzaXMvX2N1c3RvbV9iYXNpcy5weQ==) | `85.71% <85.71%> (ø)` | | | [skfda/tests/test\_custom\_basis.py](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/495/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvdGVzdHMvdGVzdF9jdXN0b21fYmFzaXMucHk=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Ddelval commented 2 years ago

The mypy decorator errors are still present (even though the action passes), but the other typing errors have been fixed.