search

GAA-UAM / scikit-fda

Functional Data Analysis Python package
https://fda.readthedocs.io
BSD 3-Clause "New" or "Revised" License
287 stars 51 forks source link

Hotfix: Correct the order of the parameters for the FPCA in Mahalanobis #506

Closed m5signorini closed 1 year ago

m5signorini commented 1 year ago

The constructor for FPCA receives parameters in a different order than the one used in Mahalanobis.

https://github.com/GAA-UAM/scikit-fda/blob/05a35df781d65918d8730195f61a93a72198f2e1/skfda/preprocessing/dim_reduction/_fpca.py#L87-L94

Thus, the last two parameters should be interchanged in the call to the constructor in Mahalanobis.

codecov[bot] commented 1 year ago

Codecov Report

Base: 85.53% // Head: 85.53% // No change to project coverage :thumbsup:

Coverage data is based on head (af8aafb) compared to base (42d0cdb). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #506 +/- ## ======================================== Coverage 85.53% 85.53% ======================================== Files 141 141 Lines 11280 11280 ======================================== Hits 9648 9648 Misses 1632 1632 ``` | [Impacted Files](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/506?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM) | Coverage Δ | | |---|---|---| | [skfda/misc/metrics/\_mahalanobis.py](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/506?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvbWlzYy9tZXRyaWNzL19tYWhhbGFub2Jpcy5weQ==) | `83.72% <ø> (ø)` | | | [skfda/preprocessing/dim\_reduction/\_fpca.py](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/506?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvcHJlcHJvY2Vzc2luZy9kaW1fcmVkdWN0aW9uL19mcGNhLnB5) | `91.20% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.