search

GAA-UAM / scikit-fda

Functional Data Analysis Python package
https://fda.readthedocs.io
BSD 3-Clause "New" or "Revised" License
287 stars 51 forks source link

Speed up the calculation of the penalization matrix for FDataGrid #519

Closed Ddelval closed 1 year ago

Ddelval commented 1 year ago

Taking advantage of the sparsity of the penalization matrix, it is possible to improve the time complexity of its calculation significantly

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 93.25% and project coverage change: +0.01 :tada:

Comparison is base (0154d69) 85.75% compared to head (f69db8f) 85.77%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #519 +/- ## =========================================== + Coverage 85.75% 85.77% +0.01% =========================================== Files 144 145 +1 Lines 11428 11500 +72 =========================================== + Hits 9800 9864 +64 - Misses 1628 1636 +8 ``` | [Impacted Files](https://app.codecov.io/gh/GAA-UAM/scikit-fda/pull/519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM) | Coverage Δ | | |---|---|---| | [skfda/representation/basis/\_grid\_basis.py](https://app.codecov.io/gh/GAA-UAM/scikit-fda/pull/519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvcmVwcmVzZW50YXRpb24vYmFzaXMvX2dyaWRfYmFzaXMucHk=) | `80.00% <80.00%> (ø)` | | | [...da/misc/operators/\_linear\_differential\_operator.py](https://app.codecov.io/gh/GAA-UAM/scikit-fda/pull/519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvbWlzYy9vcGVyYXRvcnMvX2xpbmVhcl9kaWZmZXJlbnRpYWxfb3BlcmF0b3IucHk=) | `95.74% <96.07%> (-0.18%)` | :arrow_down: | | [skfda/preprocessing/dim\_reduction/\_fpca.py](https://app.codecov.io/gh/GAA-UAM/scikit-fda/pull/519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvcHJlcHJvY2Vzc2luZy9kaW1fcmVkdWN0aW9uL19mcGNhLnB5) | `89.84% <100.00%> (-0.08%)` | :arrow_down: | | [skfda/representation/basis/\_custom\_basis.py](https://app.codecov.io/gh/GAA-UAM/scikit-fda/pull/519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvcmVwcmVzZW50YXRpb24vYmFzaXMvX2N1c3RvbV9iYXNpcy5weQ==) | `86.25% <100.00%> (ø)` | | | [skfda/tests/test\_linear\_differential\_operator.py](https://app.codecov.io/gh/GAA-UAM/scikit-fda/pull/519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvdGVzdHMvdGVzdF9saW5lYXJfZGlmZmVyZW50aWFsX29wZXJhdG9yLnB5) | `98.50% <100.00%> (+0.39%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/GAA-UAM/scikit-fda/pull/519/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.