search

GAA-UAM / scikit-fda

Functional Data Analysis Python package
https://fda.readthedocs.io
BSD 3-Clause "New" or "Revised" License
287 stars 51 forks source link

SRSF doc wrong formula #530

Closed ego-thales closed 1 year ago

ego-thales commented 1 year ago

Hello,

I just wanted to point out that the SRSF doc defines $$SRSF(f) := \text{sign}(f)\sqrt{\vert f'\vert},$$ instead of (notice the derivative in the sign function) $$SRSF(f) := \text{sign}(f')\sqrt{\vert f'\vert}.$$

Cheers

ego-thales commented 1 year ago

Edited the issue since the code isn't bugged as I thought it might be at first glance.

vnmabus commented 1 year ago

Thank you for reporting it! Do you want to provide a fix?

ego-thales commented 1 year ago

Ok I will, but probably later next week :+1:

vnmabus commented 1 year ago

Solved in #542.