GAA-UAM / scikit-fda

Functional Data Analysis Python package
https://fda.readthedocs.io
BSD 3-Clause "New" or "Revised" License
309 stars 58 forks source link

Change type of axis in FData's mean method to accept zero. #546

Closed Ddelval closed 1 year ago

Ddelval commented 1 year ago

As the documention specifies, axis can be either None or 0. Currently, if 0 is given as the axis, a mypy error is raised since the function signature only accepts a None axis.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (c40e372) 85.77% compared to head (99906d8) 85.77%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #546 +/- ## ======================================== Coverage 85.77% 85.77% ======================================== Files 145 145 Lines 11500 11500 ======================================== Hits 9864 9864 Misses 1636 1636 ``` | [Impacted Files](https://app.codecov.io/gh/GAA-UAM/scikit-fda/pull/546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM) | Coverage Δ | | |---|---|---| | [skfda/representation/\_functional\_data.py](https://app.codecov.io/gh/GAA-UAM/scikit-fda/pull/546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvcmVwcmVzZW50YXRpb24vX2Z1bmN0aW9uYWxfZGF0YS5weQ==) | `83.56% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.