Closed Ddelval closed 1 year ago
Attention: 16 lines
in your changes are missing coverage. Please review.
Comparison is base (
4207c4d
) 86.27% compared to head (e0c4ab5
) 86.67%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The requested changes are minor. @Ddelval, if you do not have time/will for doing them I can finish this PR myself and merge it. However, I would really appreciate if you could spare a few minutes to answer my questions, as you are way more familiar with the algorithm.
Hi @vnmabus, I believe I should have some time towards the end of next week. I already had a look at your comments a while ago, but I didn't have the time to reply. I haven't had much time lately, but I'm hoping that'll improve a bit this week.
Hi @vnmabus. Sorry for the delay. It seems like I tend to overestimate the amount of free time I have 🙃.
Anyway, I replied to most of your comments. Additionally, I changed the behavior when not all requested components can be extracted. This will happen, for example, if the range of the data matrices is less than n_components
. Right now, as many components as possible are returned., and a warning is raised when this happens.
Hi @vnmabus, I'm getting an error in test_regression
in some test runs. Could you have a look at it? I had a look, and I couldn't find any recent changes that could make the assert fail.
This implementation of FPLS accepts multivariate or functional data. Either X or Y can be multivariate or functional. Regularization in functional blocks is also implemented. Regarding the regression functionality, PLSRegression also accepts functional or multivariate data as the regressor or the response. However, the functional response of the PLS regressor cannot be regularized.