search

GAA-UAM / scikit-fda

Functional Data Analysis Python package
https://fda.readthedocs.io
BSD 3-Clause "New" or "Revised" License
308 stars 58 forks source link

Update mypy workflow #549

Closed Ddelval closed 1 year ago

Ddelval commented 1 year ago

Currently, the mypy action does not find all errors and reports some false positives. For example, it consistently outputs:

Untyped decorator makes function "test_simple_regresion_dataset_functional" untyped [misc]

This is because the current action does not install the required Python packages for mypy to have all the typing information it needs.

Additionally, I think the action should fail when there are mypy errors. The current configuration still marks it as a success in the pull request test summary.

I tested these changes in the PLS pull request, and they work.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (4da5cba) 85.77% compared to head (d293fc3) 85.77%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #549 +/- ## ======================================== Coverage 85.77% 85.77% ======================================== Files 145 145 Lines 11500 11500 ======================================== Hits 9864 9864 Misses 1636 1636 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.