Open m5signorini opened 1 year ago
Attention: 6 lines
in your changes are missing coverage. Please review.
Comparison is base (
7488932
) 86.67% compared to head (5c30710
) 86.14%. Report is 1 commits behind head on develop.:exclamation: Current head 5c30710 differs from pull request most recent head 5655385. Consider uploading reports for the commit 5655385 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Current test errors occur in test_pandas_fdatabasis
and test_pandas_fdatagrid
.
They say that the fixture all_boolean_reductions
can not found.
@m5signorini Maybe I wasn't clear. I was asking if there is anything else that you wanted to include, as the PR is marked as a draft, or if I have your permission to merge it.
Yes sorry, forgot to change it from draft. I think it can be merged.
Thank you for your answer! However, a test is failing (and the difference between the expected and actual result is too high). Can you take a look at it?
This PR adds the RKHS inner product.
Cases regarding the product between
FDataBasis
objects with different basis or with the covariance function not already expressed in the tensor basis, might be better to not consider them.