GAA-UAM / scikit-fda

Functional Data Analysis Python package
https://fda.readthedocs.io
BSD 3-Clause "New" or "Revised" License
309 stars 58 forks source link

BSplineBasis initialization incorrect error message #577

Closed pcuestas closed 1 year ago

pcuestas commented 1 year ago

Fix message and condition (n_basis < order) in the initialization of a BSplineBasis.

Current condition is equivalent to previous one. The message has been corrected to match the condition.

Closes #575

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (3fb0ea9) 86.06% compared to head (f441653) 86.06%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #577 +/- ## ======================================== Coverage 86.06% 86.06% ======================================== Files 147 147 Lines 11686 11686 ======================================== Hits 10058 10058 Misses 1628 1628 ``` | [Files](https://app.codecov.io/gh/GAA-UAM/scikit-fda/pull/577?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM) | Coverage Δ | | |---|---|---| | [skfda/representation/basis/\_bspline\_basis.py](https://app.codecov.io/gh/GAA-UAM/scikit-fda/pull/577?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvcmVwcmVzZW50YXRpb24vYmFzaXMvX2JzcGxpbmVfYmFzaXMucHk=) | `86.32% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.