search

GAA-UAM / scikit-fda

Functional Data Analysis Python package
https://fda.readthedocs.io
BSD 3-Clause "New" or "Revised" License
307 stars 58 forks source link

Set `correction=0` by default in cov and var functions #582

Closed pcuestas closed 1 year ago

pcuestas commented 1 year ago

(and explicitly set the correction value where it was not set, to avoid changing the previous behavior of the modules).

Closes #581

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (febfe36) 86.03% compared to head (e4a35c7) 86.03%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #582 +/- ## ======================================== Coverage 86.03% 86.03% ======================================== Files 148 148 Lines 11717 11717 ======================================== Hits 10081 10081 Misses 1636 1636 ``` | [Files](https://app.codecov.io/gh/GAA-UAM/scikit-fda/pull/582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM) | Coverage Δ | | |---|---|---| | [skfda/exploratory/stats/\_stats.py](https://app.codecov.io/gh/GAA-UAM/scikit-fda/pull/582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvZXhwbG9yYXRvcnkvc3RhdHMvX3N0YXRzLnB5) | `85.00% <100.00%> (ø)` | | | [skfda/inference/anova/\_anova\_oneway.py](https://app.codecov.io/gh/GAA-UAM/scikit-fda/pull/582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvaW5mZXJlbmNlL2Fub3ZhL19hbm92YV9vbmV3YXkucHk=) | `89.15% <ø> (ø)` | | | [skfda/inference/hotelling/\_hotelling.py](https://app.codecov.io/gh/GAA-UAM/scikit-fda/pull/582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvaW5mZXJlbmNlL2hvdGVsbGluZy9faG90ZWxsaW5nLnB5) | `91.78% <ø> (ø)` | | | [skfda/misc/covariances.py](https://app.codecov.io/gh/GAA-UAM/scikit-fda/pull/582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvbWlzYy9jb3ZhcmlhbmNlcy5weQ==) | `84.40% <100.00%> (ø)` | | | [skfda/representation/\_functional\_data.py](https://app.codecov.io/gh/GAA-UAM/scikit-fda/pull/582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvcmVwcmVzZW50YXRpb24vX2Z1bmN0aW9uYWxfZGF0YS5weQ==) | `83.15% <ø> (ø)` | | | [skfda/representation/basis/\_fdatabasis.py](https://app.codecov.io/gh/GAA-UAM/scikit-fda/pull/582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvcmVwcmVzZW50YXRpb24vYmFzaXMvX2ZkYXRhYmFzaXMucHk=) | `82.21% <ø> (ø)` | | | [skfda/representation/grid.py](https://app.codecov.io/gh/GAA-UAM/scikit-fda/pull/582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvcmVwcmVzZW50YXRpb24vZ3JpZC5weQ==) | `87.30% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.