Remove support for Python 3.9. - Githubissues

GAA-UAM / scikit-fda

Functional Data Analysis Python package

https://fda.readthedocs.io

BSD 3-Clause "New" or "Revised" License

307 stars 58 forks source link

Remove support for Python 3.9. #602

Closed vnmabus closed 8 months ago

vnmabus commented 8 months ago

Describe the proposed changes

Remove support for Python 3.9 according to SPEC 0.
Fix test discrepancies with newer Scipy versions.

SciPy version 1.11 changes how Simpson quadrature is computed with an even number of points (https://github.com/scipy/scipy/pull/18209).

This caused some test to fail, as the values of the integrals and metrics used change, causing in some cases several discrepancies (https://github.com/GAA-UAM/scikit-fda/issues/551).

This has been fixed to make the tests compatible with both previous versions and versions after 1.11, in two main ways:

By making some comparisons more lenient, allowing for higher relative or absolute tolerances.
By rewriting some tests in order to be less sensitive to changes in quadrature by design.

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] The code conforms to the style used in this package
[x] The code is fully documented and typed (type-checked with Mypy)
[x] I have added thorough tests for the new/changed functionality

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.61%. Comparing base (3eb8ace) to head (8946b3f).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #602 +/- ## =========================================== - Coverage 86.67% 86.61% -0.07% =========================================== Files 153 153 Lines 12390 12400 +10 =========================================== + Hits 10739 10740 +1 - Misses 1651 1660 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.