GAA-UAM / scikit-fda

Functional Data Analysis Python package
https://fda.readthedocs.io
BSD 3-Clause "New" or "Revised" License
308 stars 58 forks source link

Clustering example error fixed #635

Closed luisheb closed 1 month ago

luisheb commented 1 month ago

References to issues or other PRs

No issue was reported regarding the error in the clustering example.

Describe the proposed changes

In the clustering example, a couple of the explanations of the code did not match the code itself. For instance you could read:

To see the information in a graphic way, the method plot_clusters() can be used.

However, instead of using plot_clusters(), the following class was used:

ClusterPlot(kmeans, fd, cluster_colors=cluster_colors, cluster_labels=cluster_labels).plot()

Checklist before requesting a review

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.83%. Comparing base (d0bc82f) to head (2f48baa). Report is 3 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #635 +/- ## ======================================== Coverage 86.83% 86.83% ======================================== Files 157 157 Lines 13522 13522 ======================================== Hits 11742 11742 Misses 1780 1780 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vnmabus commented 1 month ago

@all-contributors Please add @luisheb for documentation.

allcontributors[bot] commented 1 month ago

@vnmabus

I've put up a pull request to add @luisheb! :tada: