search

GAIA-X4PLC-AAD / gx-credentials

TP 1: Create portable verified credentials on Tezos with public accounts
Apache License 2.0
8 stars 4 forks source link

DID:PKH:TZ is wrong #26

Open jdsika opened 7 months ago

jdsika commented 7 months ago

currently: "id": "did:pkh:tz:tz1WvvbEGpBXGeTVbLiR6DYBe1izmgiYuZbq",

According to spec here

"id": "did:pkh:tezos:mainnet:tz1WvvbEGpBXGeTVbLiR6DYBe1izmgiYuZbq", "id": "did:pkh:tezos:NetXdQprcVkpaWU:tz1WvvbEGpBXGeTVbLiR6DYBe1izmgiYuZbq",

Update: added "pkh" which I left out by mistake if you compare it with the link to the example

jfelixh commented 6 months ago

Where is the current example from? To my knowledge, we are not using did:tezos at all. At least for now, the idea was to fully rely on did:pkh:tz, to avoid the need for a connection to a ledger node. That simplifies development and test deployments.

jdsika commented 6 months ago

It was just a typo on my side which I corrected now if you open the table with examples

jdsika commented 6 months ago

The library from spruce is apparently not aligned with the specification draft of did:pkh I linked above.

jfelixh commented 6 months ago

Thanks for clarifying! I was so confused I did not even look at the link. You found a mistake indeed, but I cannot pin it on spruce, because we only use it for the signature itself. We manually construct the DID in our code, so this is a bug that we need to fix in the next version.