search

GAIA-X4PLC-AAD / ontology-management-base

Our implementation for an open automated ontology management process for GAIA-X interoperable ecosystems. Please use a community agreed domain specific class or if not yet available please create a new class and submit it for review.
Other
2 stars 0 forks source link

Ontology general #27

Closed jtdemer closed 3 weeks ago

jtdemer commented 2 months ago

Description

This ontology was created by @MircoNierenz with the latest version of the Ontology Creator and uses the current Excel file as input: Metadata, which was created in collaboration with all data providers from the GAIA-X4PLCC-AAD project and can now be merged into the main branch.

We should use the current status of the ttl-files to test it and to modify it to the needs and requierements from our ecosystem.

So everybody who has to build an domain specific Shacl- and Ontology - File can learn from here.

jtdemer commented 2 months ago

@MircoNierenz the DCO failed because youe need to signed of your commit. You can find more info here: https://github.com/GAIA-X4PLC-AAD/ontology-management-base/pull/27/checks?check_run_id=24527146200 Or run these commands: To add your Signed-off-by line to every commit in this branch:

Ensure you have a local copy of your branch by checking out the pull request locally via command line. In your local branch, run: git rebase HEAD~4 --signoff Force push your changes to overwrite the branch: git push --force-with-lease origin Ontology_General

robertschubert commented 2 months ago

see review remarks. @Novak-Zsolt @jdsika Please feel free to add something.

jdsika commented 1 month ago

Classes PascalCase Properties camlCase

robertschubert commented 1 month ago

@MircoNierenz I resolved the fixed threads. But there are still some open points, see my review comments from today.

robertschubert commented 1 month ago

@MircoNierenz One open question and two new review comment, see above.

robertschubert commented 1 month ago

@jtdemer @MircoNierenz We also need a new entry in CODEOWNERs which means that you have to define the responsible person for general

robertschubert commented 1 month ago

@jtdemer @MircoNierenz in addition: there is a new guideline that the folder name should be the same as the prefix. So please change the folder name General to general

robertschubert commented 1 month ago

Last but not least we need a general_instance.json which should contain the claims as described in the readme.

MircoNierenz commented 1 month ago

@jtdemer @MircoNierenz in addition: there is a new guideline that the folder name should be the same as the prefix. So please change the folder name General to general

fixed!

robertschubert commented 4 weeks ago

Last but not least we need a general_instance.json which should contain the claims as described in the readme.

This is also missing.

robertschubert commented 3 weeks ago

@MircoNierenz I added general_instance.json

robertschubert commented 3 weeks ago

@lenasauermann can you please add your approval so we can merge this one?

lenasauermann commented 3 weeks ago

@MircoNierenz can you take a look at the small issues I found?

robertschubert commented 3 weeks ago

@lenasauermann looks good for me. Can you add an approval and merge to master?