Update domain class environment-model

GAIA-X4PLC-AAD / ontology-management-base

Our implementation for an open automated ontology management process for GAIA-X interoperable ecosystems. Please use a community agreed domain specific class or if not yet available please create a new class and submit it for review.

Other

2 stars 0 forks source link

Update domain class environment-model #31

Closed jtdemer closed 2 weeks ago

jtdemer commented 1 month ago

Type of change

main work was done by Mirco:

Adjustments regarding name convention
add sub categories
add string enums
add Georefernce shape

I ajust the the foldername regarding the lived naming convention

How Has This Been Tested?

Shacl File was uploaded into the self creation wizard

Checklist

[x] My code follows the modelling guidelines of this project
[x] I have performed a self-review of my own changes

robertschubert commented 1 month ago

@jtdemer Looks good :) One thing I did not see in the first review: We need the functional responsible person for this ontology. Can you figure out who this can be? Can you add a section into the CODEOWNERs file? After this an a second approval by this person this PR can be merged.

Please also add an environment-model_instance.json

robertschubert commented 1 month ago

@jtdemer can you also rename the example file? it should be written as ontology and shacl followed with an underscore ("_instance.json"). environment-model_instance.json.

jtdemer commented 1 month ago

@jtdemer can you also rename the example file? it should be written as ontology and shacl followed with an underscore ("_instance.json"). environment-model_instance.json.

done

MircoNierenz commented 1 month ago

my new version was not commited, was it? I have now done this and also the adjustments from the other branches. Please have a look.

robertschubert commented 4 weeks ago

my new version was not commited, was it? I have now done this and also the adjustments from the other branches. Please have a look.

@MircoNierenz there is no commit from you (see commit tab on the top):

Please give me a short information if you need help.

@jtdemer we still need a function owner in the CODEOWNERS file (see comment from May 22nd.

jtdemer commented 4 weeks ago

my new version was not commited, was it? I have now done this and also the adjustments from the other branches. Please have a look.

@MircoNierenz there is no commit from you (see commit tab on the top):

Please give me a short information if you need help.

@jtdemer we still need a function owner in the CODEOWNERS file (see comment from May 22nd.

done

MircoNierenz commented 4 weeks ago

my new version was not commited, was it? I have now done this and also the adjustments from the other branches. Please have a look.

@MircoNierenz there is no commit from you (see commit tab on the top):

I have commited to the new environment-model branch!

MircoNierenz commented 3 weeks ago

please sove pull request outdated? see branch environment-model and https://github.com/GAIA-X4PLC-AAD/ontology-management-base/pull/44 and merge into main the environment-model ontology in the main branch is not up to date!

robertschubert commented 3 weeks ago

@MircoNierenz Nothing is outdated here. #44 is a different branch so the changes there are not visible in this branch. Not good that we have two PRs simultanously for the same ontology. We will have merge conflicts I guess. But I can merge this one and then the merge conflicts have to be solved.

Please note to reassign the issue to the reviewer when you are done with the incorporation.

robertschubert commented 3 weeks ago

@MircoNierenz Or is one of the two branches / PRs for environment model obsolete? Still we need a second approval so I will not do the merge now.

MircoNierenz commented 3 weeks ago

had missed that this pull request is already for branch environment-model - due to the different naming of the PR. I had therefore made my own PR.

then the PR https://github.com/GAIA-X4PLC-AAD/ontology-management-base/pull/44 should be obsolete.

robertschubert commented 3 weeks ago

@MircoNierenz Then please close PR https://github.com/GAIA-X4PLC-AAD/ontology-management-base/pull/44 and incorporate the review comments from above into this PR. They are still open and I cannot merge this.

@lenasauermann after the review comments are incorporated can you please do another approval?

robertschubert commented 2 weeks ago

@MircoNierenz there are still 3 open review comments, see above. Please solve this review comments and then I can do the final merge.

robertschubert commented 2 weeks ago

@MircoNierenz I cannot see any commit and the issues are still not resolved in the code. I reopened the conversation. To summarize:

still "nan" as example
"GeoreferenceShape" is defined locally. Shouldn't you take the globally defined? If yes you will also need to update the _instance file
still 0.1"^^xsd:float in the ontology file.

robertschubert commented 2 weeks ago

I can do the "resolve conflicts" for you

MircoNierenz commented 2 weeks ago

this pull request is outdated! reference to wrong branch (environment-model vs Ontology_Environment)! see new pull request https://github.com/GAIA-X4PLC-AAD/ontology-management-base/pull/50 for Ontology_Environment branch