Marcelbrucker code rework

GAIL-4-BARK / bark-ml

Machine Learning Applied to Autonomous Driving

MIT License

0 stars 0 forks source link

Marcelbrucker code rework #68

Closed marcelbrucker closed 4 years ago

marcelbrucker commented 4 years ago

Carried out

general: param_server["Scenario"]["Generation"]["InteractionDatasetScenarioGeneration"][....] can be shortened using local_params = param_server["Scenario"]["Generation"]["InteractionDatasetScenarioGeneration"] plus local_params[...]
correct some spelling mistakes in the notebook
added explanations for states and actions in notebook

MarcelBruckner commented 4 years ago

I just saw that there are many more locations where we can apply this shortening:

bark_ml/library_wrappers/lib_tf2rl/generate_expert_trajectories.py
bark_ml/tests/py_library_tf2rl_tests/base_tests.py
bark_ml/tests/py_library_tf2rl_tests/simulation_based_tests.py
bark-ml/docs/report/gail.ipynb
Some more

You can find them with ctrl + shift + f to global search for param_server

marcelbrucker commented 4 years ago

I just saw that there are many more locations where we can apply this shortening:

bark_ml/library_wrappers/lib_tf2rl/generate_expert_trajectories.py

bark_ml/tests/py_library_tf2rl_tests/base_tests.py

bark_ml/tests/py_library_tf2rl_tests/simulation_based_tests.py

bark-ml/docs/report/gail.ipynb

Some more

You can find them with ctrl + shift + f to global search for param_server

I don't see how this should work in most of your suggested files when a param_server is filled with values (<--) instead of accessing many values from the same block of a param_server (-->). But I did it once more in * bark_ml/library_wrappers/lib_tf2rl/generate_expert_trajectories.py .

MarcelBruckner commented 4 years ago

I just saw that there are many more locations where we can apply this shortening:

bark_ml/library_wrappers/lib_tf2rl/generate_expert_trajectories.py

bark_ml/tests/py_library_tf2rl_tests/base_tests.py

bark_ml/tests/py_library_tf2rl_tests/simulation_based_tests.py

bark-ml/docs/report/gail.ipynb

Some more

You can find them with ctrl + shift + f to global search for param_server

I don't see how this should work in most of your suggested files when a param_server is filled with values (<--) instead of accessing many values from the same block of a param_server (-->). But I did it once more in * bark_ml/library_wrappers/lib_tf2rl/generate_expert_trajectories.py .

Like this: https://github.com/GAIL-4-BARK/bark-ml/pull/68/commits/2afc0c1eadebe9739dfdb5ffa0b786104ef313ef I already changed it so that I can now merge it :+1: