Implement new Cloud Identity Groups transitive (inherited) membership endpoints

GAM-team / GAM

command line management for Google Workspace

https://github.com/GAM-team/GAM/wiki

Apache License 2.0

3.5k stars 468 forks source link

Implement new Cloud Identity Groups transitive (inherited) membership endpoints #1262

Open jay0lee opened 3 years ago

jay0lee commented 3 years ago

Cloud Identity Groups API has added a number of API calls that allow looking at the direct and indirect membership of a group:

https://cloud.google.com/identity/docs/how-to/query-memberships

ideally GAM would also add this functionality. @taers232c FYI if you have cycles to kill.

jay0lee commented 3 years ago

How about:

gam print course-invitations

with options to set course / user and limit the results. This would be pretty similar to:

https://github.com/jay0lee/GAM/blob/master/src/gam/__init__.py#L2482

uninvite would be same syntax as invite.

Bonus points if you can start moving these functions into a new src/gam/gapi/classroom/invites.py file similar to other moves and getting them out of init.py but that can also be done later.

taers232c commented 3 years ago

Jay,

I'll work on this today.

Ross

ross.scroggs@gmail.com

On Oct 9, 2020, at 7:44 AM, Jay Lee notifications@github.com wrote:

Cloud Identity Groups API has added a number of API calls that allow looking at the direct and indirect membership of a group:

https://cloud.google.com/identity/docs/how-to/query-memberships https://cloud.google.com/identity/docs/how-to/query-memberships ideally GAM would also add this functionality. @taers232c https://github.com/taers232c FYI if you have cycles to kill.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jay0lee/GAM/issues/1262, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCTYLZ7PIDGRU6EWWFHFODSJ4OVZANCNFSM4SKFMTHQ.

taers232c commented 3 years ago

Unfortunately, the discovery document is not up to date, it doesn't include the query parameter.

ross.scroggs@gmail.com

On Oct 11, 2020, at 4:34 AM, Ross Scroggs ross.scroggs@gmail.com wrote:

Jay,

I'll work on this today.

Ross

ross.scroggs@gmail.com mailto:ross.scroggs@gmail.com

On Oct 9, 2020, at 7:44 AM, Jay Lee <notifications@github.com mailto:notifications@github.com> wrote:

Cloud Identity Groups API has added a number of API calls that allow looking at the direct and indirect membership of a group:

https://cloud.google.com/identity/docs/how-to/query-memberships https://cloud.google.com/identity/docs/how-to/query-memberships ideally GAM would also add this functionality. @taers232c https://github.com/taers232c FYI if you have cycles to kill.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jay0lee/GAM/issues/1262, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCTYLZ7PIDGRU6EWWFHFODSJ4OVZANCNFSM4SKFMTHQ.

jay0lee commented 3 years ago

Which command are you referring to?

On Sun, Oct 11, 2020, 8:21 AM Ross Scroggs notifications@github.com wrote:

Unfortunately, the discovery document is not up to date, it doesn't include the query parameter.

ross.scroggs@gmail.com

On Oct 11, 2020, at 4:34 AM, Ross Scroggs ross.scroggs@gmail.com wrote:

Jay,

I'll work on this today.

Ross

ross.scroggs@gmail.com mailto:ross.scroggs@gmail.com

On Oct 9, 2020, at 7:44 AM, Jay Lee <notifications@github.com <mailto: notifications@github.com>> wrote:

Cloud Identity Groups API has added a number of API calls that allow looking at the direct and indirect membership of a group:

https://cloud.google.com/identity/docs/how-to/query-memberships < https://cloud.google.com/identity/docs/how-to/query-memberships> ideally GAM would also add this functionality. @taers232c < https://github.com/taers232c> FYI if you have cycles to kill.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/jay0lee/GAM/issues/1262>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACCTYLZ7PIDGRU6EWWFHFODSJ4OVZANCNFSM4SKFMTHQ .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jay0lee/GAM/issues/1262#issuecomment-706696714, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDIZMDORSC6MXWOR5PVPKLSKGPK7ANCNFSM4SKFMTHQ .

taers232c commented 3 years ago

This page shows the use of the query parameter: https://cloud.google.com/identity/docs/how-to/query-memberships#searching_for_all_group_memberships_of_a_member https://cloud.google.com/identity/docs/how-to/query-memberships#searching_for_all_group_memberships_of_a_member https://cloud.google.com/identity/docs/how-to/query-memberships#searching_for_all_group_memberships_of_a_member https://cloud.google.com/identity/docs/how-to/query-memberships#searching_for_all_group_memberships_of_a_member https://cloud.google.com/identity/docs/how-to/query-memberships#searching_for_all_group_memberships_of_a_member

On this page there is no query parameter: https://cloud.google.com/identity/docs/reference/rest/v1beta1/groups.memberships/searchTransitiveMemberships https://cloud.google.com/identity/docs/reference/rest/v1beta1/groups.memberships/searchTransitiveMemberships

Here's the relevant section from the discovery document, there's no query parameter. "searchTransitiveMemberships": { "parameterOrder": [ "parent" ], "response": { "$ref": "SearchTransitiveMembershipsResponse" }, "path": "v1beta1/{+parent}/memberships:searchTransitiveMemberships", "httpMethod": "GET", "parameters": { "pageToken": { "type": "string", "description": "The next_page_token value returned from a previous list request, if any.", "location": "query" }, "pageSize": { "type": "integer", "format": "int32", "location": "query", "description": "The default page size is 200 (max 1000)." }, "parent": { "type": "string", "location": "path", "pattern": "^groups/[^/]+$", "required": true, "description": "Resource name of the group to search transitive memberships in. Format: groups/{group_id}, where group_id is the unique ID assigned to the Group." } }, "description": "Search transitive memberships of a group.", "id": "cloudidentity.groups.memberships.searchTransitiveMemberships", "flatPath": "v1beta1/groups/{groupsId}/memberships:searchTransitiveMemberships", "scopes": [ "https://www.googleapis.com/auth/cloud-identity.groups", "https://www.googleapis.com/auth/cloud-identity.groups.readonly", "https://www.googleapis.com/auth/cloud-platform" ] } }

-- ross.scroggs@gmail.com

On Oct 11, 2020, at 5:52 AM, Jay Lee notifications@github.com wrote:

Which command are you referring to?

On Sun, Oct 11, 2020, 8:21 AM Ross Scroggs notifications@github.com wrote:

Unfortunately, the discovery document is not up to date, it doesn't include the query parameter.

ross.scroggs@gmail.com

On Oct 11, 2020, at 4:34 AM, Ross Scroggs ross.scroggs@gmail.com wrote:

Jay,

I'll work on this today.

Ross

ross.scroggs@gmail.com mailto:ross.scroggs@gmail.com

On Oct 9, 2020, at 7:44 AM, Jay Lee <notifications@github.com <mailto: notifications@github.com>> wrote:

Cloud Identity Groups API has added a number of API calls that allow looking at the direct and indirect membership of a group:

https://cloud.google.com/identity/docs/how-to/query-memberships < https://cloud.google.com/identity/docs/how-to/query-memberships> ideally GAM would also add this functionality. @taers232c < https://github.com/taers232c> FYI if you have cycles to kill.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/jay0lee/GAM/issues/1262>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACCTYLZ7PIDGRU6EWWFHFODSJ4OVZANCNFSM4SKFMTHQ .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jay0lee/GAM/issues/1262#issuecomment-706696714, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDIZMDORSC6MXWOR5PVPKLSKGPK7ANCNFSM4SKFMTHQ .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jay0lee/GAM/issues/1262#issuecomment-706700496, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCTYL62GLTMZGEFZBKYQB3SKGTB7ANCNFSM4SKFMTHQ.

jay0lee commented 3 years ago

I think you're confusing searchTransitiveGroups and searchTransitiveMemberships.

search transitive groups will return all groups a given user is a direct or indirect member of. The query parameter specifies the given user. Search transitive memberships will return all direct and indirect members of a group. There's no query parameter here, just a parent attribute that specifies the group.

Jay

On Sun, Oct 11, 2020, 9:02 AM Ross Scroggs notifications@github.com wrote:

This page shows the use of the query parameter: https://cloud.google.com/identity/docs/how-to/query-memberships#searching_for_all_group_memberships_of_a_member < https://cloud.google.com/identity/docs/how-to/query-memberships#searching_for_all_group_memberships_of_a_member

https://cloud.google.com/identity/docs/how-to/query-memberships#searching_for_all_group_memberships_of_a_member

https://cloud.google.com/identity/docs/how-to/query-memberships#searching_for_all_group_memberships_of_a_member

https://cloud.google.com/identity/docs/how-to/query-memberships#searching_for_all_group_memberships_of_a_member

On this page there is no query parameter: https://cloud.google.com/identity/docs/reference/rest/v1beta1/groups.memberships/searchTransitiveMemberships < https://cloud.google.com/identity/docs/reference/rest/v1beta1/groups.memberships/searchTransitiveMemberships

Here's the relevant section from the discovery document, there's no query parameter. "searchTransitiveMemberships": { "parameterOrder": [ "parent" ], "response": { "$ref": "SearchTransitiveMembershipsResponse" }, "path": "v1beta1/{+parent}/memberships:searchTransitiveMemberships", "httpMethod": "GET", "parameters": { "pageToken": { "type": "string", "description": "The next_page_token value returned from a previous list request, if any.", "location": "query" }, "pageSize": { "type": "integer", "format": "int32", "location": "query", "description": "The default page size is 200 (max 1000)." }, "parent": { "type": "string", "location": "path", "pattern": "^groups/[^/]+$", "required": true, "description": "Resource name of the group to search transitive memberships in. Format: groups/{group_id}, where group_id is the unique ID assigned to the Group." } }, "description": "Search transitive memberships of a group.", "id": "cloudidentity.groups.memberships.searchTransitiveMemberships", "flatPath": "v1beta1/groups/{groupsId}/memberships:searchTransitiveMemberships", "scopes": [ "https://www.googleapis.com/auth/cloud-identity.groups", "https://www.googleapis.com/auth/cloud-identity.groups.readonly", "https://www.googleapis.com/auth/cloud-platform" ] } }

-- ross.scroggs@gmail.com

On Oct 11, 2020, at 5:52 AM, Jay Lee notifications@github.com wrote:

Which command are you referring to?

On Sun, Oct 11, 2020, 8:21 AM Ross Scroggs notifications@github.com wrote:

Unfortunately, the discovery document is not up to date, it doesn't include the query parameter.

ross.scroggs@gmail.com

On Oct 11, 2020, at 4:34 AM, Ross Scroggs ross.scroggs@gmail.com wrote:

Jay,

I'll work on this today.

Ross

ross.scroggs@gmail.com mailto:ross.scroggs@gmail.com

On Oct 9, 2020, at 7:44 AM, Jay Lee <notifications@github.com <mailto: notifications@github.com>> wrote:

Cloud Identity Groups API has added a number of API calls that allow looking at the direct and indirect membership of a group:

https://cloud.google.com/identity/docs/how-to/query-memberships < https://cloud.google.com/identity/docs/how-to/query-memberships> ideally GAM would also add this functionality. @taers232c < https://github.com/taers232c> FYI if you have cycles to kill.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/jay0lee/GAM/issues/1262>, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ACCTYLZ7PIDGRU6EWWFHFODSJ4OVZANCNFSM4SKFMTHQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jay0lee/GAM/issues/1262#issuecomment-706696714, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABDIZMDORSC6MXWOR5PVPKLSKGPK7ANCNFSM4SKFMTHQ

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/jay0lee/GAM/issues/1262#issuecomment-706700496>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACCTYL62GLTMZGEFZBKYQB3SKGTB7ANCNFSM4SKFMTHQ .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jay0lee/GAM/issues/1262#issuecomment-706701742, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDIZMGI52POTG4IJEBLAATSKGUHJANCNFSM4SKFMTHQ .

taers232c commented 3 years ago

Graack! Thank you!

ross.scroggs@gmail.com

On Oct 11, 2020, at 6:16 AM, Jay Lee notifications@github.com wrote:

I think you're confusing searchTransitiveGroups and searchTransitiveMemberships.

search transitive groups will return all groups a given user is a direct or indirect member of. The query parameter specifies the given user. Search transitive memberships will return all direct and indirect members of a group. There's no query parameter here, just a parent attribute that specifies the group.

Jay

On Sun, Oct 11, 2020, 9:02 AM Ross Scroggs notifications@github.com wrote:

This page shows the use of the query parameter: https://cloud.google.com/identity/docs/how-to/query-memberships#searching_for_all_group_memberships_of_a_member < https://cloud.google.com/identity/docs/how-to/query-memberships#searching_for_all_group_memberships_of_a_member

https://cloud.google.com/identity/docs/how-to/query-memberships#searching_for_all_group_memberships_of_a_member

https://cloud.google.com/identity/docs/how-to/query-memberships#searching_for_all_group_memberships_of_a_member

https://cloud.google.com/identity/docs/how-to/query-memberships#searching_for_all_group_memberships_of_a_member

On this page there is no query parameter: https://cloud.google.com/identity/docs/reference/rest/v1beta1/groups.memberships/searchTransitiveMemberships < https://cloud.google.com/identity/docs/reference/rest/v1beta1/groups.memberships/searchTransitiveMemberships

Here's the relevant section from the discovery document, there's no query parameter. "searchTransitiveMemberships": { "parameterOrder": [ "parent" ], "response": { "$ref": "SearchTransitiveMembershipsResponse" }, "path": "v1beta1/{+parent}/memberships:searchTransitiveMemberships", "httpMethod": "GET", "parameters": { "pageToken": { "type": "string", "description": "The next_page_token value returned from a previous list request, if any.", "location": "query" }, "pageSize": { "type": "integer", "format": "int32", "location": "query", "description": "The default page size is 200 (max 1000)." }, "parent": { "type": "string", "location": "path", "pattern": "^groups/[^/]+$", "required": true, "description": "Resource name of the group to search transitive memberships in. Format: groups/{group_id}, where group_id is the unique ID assigned to the Group." } }, "description": "Search transitive memberships of a group.", "id": "cloudidentity.groups.memberships.searchTransitiveMemberships", "flatPath": "v1beta1/groups/{groupsId}/memberships:searchTransitiveMemberships", "scopes": [ "https://www.googleapis.com/auth/cloud-identity.groups", "https://www.googleapis.com/auth/cloud-identity.groups.readonly", "https://www.googleapis.com/auth/cloud-platform" ] } }

-- ross.scroggs@gmail.com

On Oct 11, 2020, at 5:52 AM, Jay Lee notifications@github.com wrote:

Which command are you referring to?

On Sun, Oct 11, 2020, 8:21 AM Ross Scroggs notifications@github.com wrote:

Unfortunately, the discovery document is not up to date, it doesn't include the query parameter.

ross.scroggs@gmail.com

On Oct 11, 2020, at 4:34 AM, Ross Scroggs ross.scroggs@gmail.com wrote:

Jay,

I'll work on this today.

Ross

ross.scroggs@gmail.com mailto:ross.scroggs@gmail.com

On Oct 9, 2020, at 7:44 AM, Jay Lee <notifications@github.com <mailto: notifications@github.com>> wrote:

Cloud Identity Groups API has added a number of API calls that allow looking at the direct and indirect membership of a group:

https://cloud.google.com/identity/docs/how-to/query-memberships < https://cloud.google.com/identity/docs/how-to/query-memberships> ideally GAM would also add this functionality. @taers232c < https://github.com/taers232c> FYI if you have cycles to kill.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/jay0lee/GAM/issues/1262>, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ACCTYLZ7PIDGRU6EWWFHFODSJ4OVZANCNFSM4SKFMTHQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jay0lee/GAM/issues/1262#issuecomment-706696714, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABDIZMDORSC6MXWOR5PVPKLSKGPK7ANCNFSM4SKFMTHQ

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/jay0lee/GAM/issues/1262#issuecomment-706700496>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACCTYL62GLTMZGEFZBKYQB3SKGTB7ANCNFSM4SKFMTHQ .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jay0lee/GAM/issues/1262#issuecomment-706701742, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDIZMGI52POTG4IJEBLAATSKGUHJANCNFSM4SKFMTHQ .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jay0lee/GAM/issues/1262#issuecomment-706703461, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCTYL4AUTZAEDUE6R67V53SKGV3RANCNFSM4SKFMTHQ.

taers232c commented 3 years ago

OK, I go here: https://cloud.google.com/identity/docs/reference/rest/v1beta1/groups.memberships/searchTransitiveGroups https://cloud.google.com/identity/docs/reference/rest/v1beta1/groups.memberships/searchTransitiveGroups parent - groups/- query - member_key_id == 'admin@rdschool.org' && 'cloudidentity.googleapis.com/groups.discussion_forum' in labels Execute I get Bad Request { "error": { "code": 400, "message": "Request contains an invalid argument.", "status": "INVALID_ARGUMENT" } }

Is this becuase I don't have an Enterprose license?

Thanks

-- ross.scroggs@gmail.com

On Oct 11, 2020, at 6:16 AM, Jay Lee notifications@github.com wrote:

I think you're confusing searchTransitiveGroups and searchTransitiveMemberships.

search transitive groups will return all groups a given user is a direct or indirect member of. The query parameter specifies the given user. Search transitive memberships will return all direct and indirect members of a group. There's no query parameter here, just a parent attribute that specifies the group.

Jay

On Sun, Oct 11, 2020, 9:02 AM Ross Scroggs notifications@github.com wrote:

This page shows the use of the query parameter: https://cloud.google.com/identity/docs/how-to/query-memberships#searching_for_all_group_memberships_of_a_member < https://cloud.google.com/identity/docs/how-to/query-memberships#searching_for_all_group_memberships_of_a_member

https://cloud.google.com/identity/docs/how-to/query-memberships#searching_for_all_group_memberships_of_a_member

https://cloud.google.com/identity/docs/how-to/query-memberships#searching_for_all_group_memberships_of_a_member

https://cloud.google.com/identity/docs/how-to/query-memberships#searching_for_all_group_memberships_of_a_member

On this page there is no query parameter: https://cloud.google.com/identity/docs/reference/rest/v1beta1/groups.memberships/searchTransitiveMemberships < https://cloud.google.com/identity/docs/reference/rest/v1beta1/groups.memberships/searchTransitiveMemberships

Here's the relevant section from the discovery document, there's no query parameter. "searchTransitiveMemberships": { "parameterOrder": [ "parent" ], "response": { "$ref": "SearchTransitiveMembershipsResponse" }, "path": "v1beta1/{+parent}/memberships:searchTransitiveMemberships", "httpMethod": "GET", "parameters": { "pageToken": { "type": "string", "description": "The next_page_token value returned from a previous list request, if any.", "location": "query" }, "pageSize": { "type": "integer", "format": "int32", "location": "query", "description": "The default page size is 200 (max 1000)." }, "parent": { "type": "string", "location": "path", "pattern": "^groups/[^/]+$", "required": true, "description": "Resource name of the group to search transitive memberships in. Format: groups/{group_id}, where group_id is the unique ID assigned to the Group." } }, "description": "Search transitive memberships of a group.", "id": "cloudidentity.groups.memberships.searchTransitiveMemberships", "flatPath": "v1beta1/groups/{groupsId}/memberships:searchTransitiveMemberships", "scopes": [ "https://www.googleapis.com/auth/cloud-identity.groups", "https://www.googleapis.com/auth/cloud-identity.groups.readonly", "https://www.googleapis.com/auth/cloud-platform" ] } }

-- ross.scroggs@gmail.com

On Oct 11, 2020, at 5:52 AM, Jay Lee notifications@github.com wrote:

Which command are you referring to?

On Sun, Oct 11, 2020, 8:21 AM Ross Scroggs notifications@github.com wrote:

Unfortunately, the discovery document is not up to date, it doesn't include the query parameter.

ross.scroggs@gmail.com

On Oct 11, 2020, at 4:34 AM, Ross Scroggs ross.scroggs@gmail.com wrote:

Jay,

I'll work on this today.

Ross

ross.scroggs@gmail.com mailto:ross.scroggs@gmail.com

On Oct 9, 2020, at 7:44 AM, Jay Lee <notifications@github.com <mailto: notifications@github.com>> wrote:

Cloud Identity Groups API has added a number of API calls that allow looking at the direct and indirect membership of a group:

https://cloud.google.com/identity/docs/how-to/query-memberships < https://cloud.google.com/identity/docs/how-to/query-memberships> ideally GAM would also add this functionality. @taers232c < https://github.com/taers232c> FYI if you have cycles to kill.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/jay0lee/GAM/issues/1262>, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ACCTYLZ7PIDGRU6EWWFHFODSJ4OVZANCNFSM4SKFMTHQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jay0lee/GAM/issues/1262#issuecomment-706696714, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABDIZMDORSC6MXWOR5PVPKLSKGPK7ANCNFSM4SKFMTHQ

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/jay0lee/GAM/issues/1262#issuecomment-706700496>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACCTYL62GLTMZGEFZBKYQB3SKGTB7ANCNFSM4SKFMTHQ .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jay0lee/GAM/issues/1262#issuecomment-706701742, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDIZMGI52POTG4IJEBLAATSKGUHJANCNFSM4SKFMTHQ .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jay0lee/GAM/issues/1262#issuecomment-706703461, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCTYL4AUTZAEDUE6R67V53SKGV3RANCNFSM4SKFMTHQ.

NoSubstitute commented 3 years ago

I have Enterprise. Tell me how I can test.

NoSubstitute commented 3 years ago

Hi, guys. Did this not go anywhere?

taers232c commented 2 years ago

Jay,

Any issues with this?

Ross

@.***

jay0lee commented 2 years ago

I think this is merged and released but not fully documented. Am I missing something?

jay0lee commented 2 years ago

Also worth noting, I believe most of the features have hit v1 so if possible we should switch to v1.

taers232c commented 2 years ago

Jay,

Not ready for prime time.

Ross

v1beta1 - works

Getting all Members, Managers, Owners for groups/01fob9te3coo820 send: b'GET /v1beta1/groups/01fob9te3coo820/memberships?view=FULL&fields=nextPageToken%2Cmemberships%28%2A%29&pageSize=200&prettyPrint=true&alt=json HTTP/1.1\r\nHost: cloudidentity.googleapis.com\r\naccept: application/json\r\naccept-encoding: gzip, deflate\r\nuser-agent: GAMADV-XTD3 6.11.03 - https://github.com/taers232c/GAMADV-XTD3 / Ross Scroggs @.> / Python 3.10.1 final / macOS-10.13.6-x86_64-i386-64bit x86_64 / (gzip)\r\nx-goog-api-client: gdcl/2.33.0 gl-python/3.10.1\r\ncontent-length: 0\r\nauthorization: Bearer xxx\r\n\r\n' reply: 'HTTP/1.1 200 OK\r\n' header: Content-Type: application/json; charset=UTF-8 header: Vary: Origin header: Vary: X-Origin header: Vary: Referer header: Content-Encoding: gzip header: Date: Thu, 09 Dec 2021 16:38:48 GMT header: Server: ESF header: Cache-Control: private header: X-XSS-Protection: 0 header: X-Frame-Options: SAMEORIGIN header: X-Content-Type-Options: nosniff header: Alt-Svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000,h3-Q050=":443"; ma=2592000,h3-Q046=":443"; ma=2592000,h3-Q043=":443"; ma=2592000,quic=":443"; ma=2592000; v="46,43" header: Transfer-Encoding: chunked {'type': 'USER', 'name': 'groups/01fob9te3coo820/memberships/100494212331014619275', 'memberKey': {'id': @.'}, 'createTime': '2020-12-20T21:27:19.524955Z', 'updateTime': '2020-12-20T21:27:19.524955Z', 'role': 'OWNER'}

v1 - memberKey information is missing

send: b'GET /v1/groups/01fob9te3coo820/memberships?view=FULL&fields=nextPageToken%2Cmemberships%28%2A%29&pageSize=200&prettyPrint=true&alt=json HTTP/1.1\r\nHost: cloudidentity.googleapis.com\r\naccept: application/json\r\naccept-encoding: gzip, deflate\r\nuser-agent: GAMADV-XTD3 6.11.03 - https://github.com/taers232c/GAMADV-XTD3 / Ross Scroggs @.***> / Python 3.10.1 final / macOS-10.13.6-x86_64-i386-64bit x86_64 / (gzip)\r\nx-goog-api-client: gdcl/2.33.0 gl-python/3.10.1\r\ncontent-length: 0\r\nauthorization: Bearer ya29.a0ARrdaM9E6qz5nP9pOZy0AWYzqjqPTMKEDGwff2pWLf4TUp8Vnyk_uE4ViFGFkk5j4LEw98dEmpfDYWbuiSfCb9xkJ6Xf3JcHqp2Jm-qBHoHuTXL-5aiRpF5oARr7xdAi2VTZ5Wd1VgxmrV4S0swEwQvL2-9I35w\r\n\r\n' reply: 'HTTP/1.1 200 OK\r\n' header: Content-Type: application/json; charset=UTF-8 header: Vary: Origin header: Vary: X-Origin header: Vary: Referer header: Content-Encoding: gzip header: Date: Thu, 09 Dec 2021 16:40:50 GMT header: Server: ESF header: Cache-Control: private header: X-XSS-Protection: 0 header: X-Frame-Options: SAMEORIGIN header: X-Content-Type-Options: nosniff header: Alt-Svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000,h3-Q050=":443"; ma=2592000,h3-Q046=":443"; ma=2592000,h3-Q043=":443"; ma=2592000,quic=":443"; ma=2592000; v="46,43" header: Transfer-Encoding: chunked {'type': 'USER', 'name': 'groups/01fob9te3coo820/memberships/100494212331014619275', 'createTime': '2020-12-20T21:27:19.524955Z', 'updateTime': '2020-12-20T21:27:19.524955Z', 'role': 'OWNER'}

-- @.***

On Dec 9, 2021, at 7:19 AM, Jay Lee @.***> wrote:

Also worth noting, I believe most of the features have hit v1 so if possible we should switch to v1.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jay0lee/GAM/issues/1262#issuecomment-989949840, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCTYLZWB4KTYJ7X7X36NHDUQDCJDANCNFSM4SKFMTHQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

taers232c commented 2 years ago

Jay,

Ignore previous results. v1beta1 in returning memberKey, v1 is returning preferredMemberKey

Ross

@.***

On Dec 9, 2021, at 8:43 AM, Ross Scroggs @.***> wrote:

Jay,

Not ready for prime time.

Ross

v1beta1 - works

Getting all Members, Managers, Owners for groups/01fob9te3coo820 send: b'GET /v1beta1/groups/01fob9te3coo820/memberships?view=FULL&fields=nextPageToken%2Cmemberships%28%2A%29&pageSize=200&prettyPrint=true&alt=json HTTP/1.1\r\nHost: cloudidentity.googleapis.com http://cloudidentity.googleapis.com/\r\naccept: application/json\r\naccept-encoding: gzip, deflate\r\nuser-agent: GAMADV-XTD3 6.11.03 - https://github.com/taers232c/GAMADV-XTD3 https://github.com/taers232c/GAMADV-XTD3 / Ross Scroggs @. @.>> / Python 3.10.1 final / macOS-10.13.6-x86_64-i386-64bit x86_64 / (gzip)\r\nx-goog-api-client: gdcl/2.33.0 gl-python/3.10.1\r\ncontent-length: 0\r\nauthorization: Bearer xxx\r\n\r\n' reply: 'HTTP/1.1 200 OK\r\n' header: Content-Type: application/json; charset=UTF-8 header: Vary: Origin header: Vary: X-Origin header: Vary: Referer header: Content-Encoding: gzip header: Date: Thu, 09 Dec 2021 16:38:48 GMT header: Server: ESF header: Cache-Control: private header: X-XSS-Protection: 0 header: X-Frame-Options: SAMEORIGIN header: X-Content-Type-Options: nosniff header: Alt-Svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000,h3-Q050=":443"; ma=2592000,h3-Q046=":443"; ma=2592000,h3-Q043=":443"; ma=2592000,quic=":443"; ma=2592000; v="46,43" header: Transfer-Encoding: chunked {'type': 'USER', 'name': 'groups/01fob9te3coo820/memberships/100494212331014619275', 'memberKey': {'id': @. @.>'}, 'createTime': '2020-12-20T21:27:19.524955Z', 'updateTime': '2020-12-20T21:27:19.524955Z', 'role': 'OWNER'}

v1 - memberKey information is missing

send: b'GET /v1/groups/01fob9te3coo820/memberships?view=FULL&fields=nextPageToken%2Cmemberships%28%2A%29&pageSize=200&prettyPrint=true&alt=json HTTP/1.1\r\nHost: cloudidentity.googleapis.com http://cloudidentity.googleapis.com/\r\naccept: application/json\r\naccept-encoding: gzip, deflate\r\nuser-agent: GAMADV-XTD3 6.11.03 - https://github.com/taers232c/GAMADV-XTD3 https://github.com/taers232c/GAMADV-XTD3 / Ross Scroggs @. @.>> / Python 3.10.1 final / macOS-10.13.6-x86_64-i386-64bit x86_64 / (gzip)\r\nx-goog-api-client: gdcl/2.33.0 gl-python/3.10.1\r\ncontent-length: 0\r\nauthorization: Bearer ya29.a0ARrdaM9E6qz5nP9pOZy0AWYzqjqPTMKEDGwff2pWLf4TUp8Vnyk_uE4ViFGFkk5j4LEw98dEmpfDYWbuiSfCb9xkJ6Xf3JcHqp2Jm-qBHoHuTXL-5aiRpF5oARr7xdAi2VTZ5Wd1VgxmrV4S0swEwQvL2-9I35w\r\n\r\n' reply: 'HTTP/1.1 200 OK\r\n' header: Content-Type: application/json; charset=UTF-8 header: Vary: Origin header: Vary: X-Origin header: Vary: Referer header: Content-Encoding: gzip header: Date: Thu, 09 Dec 2021 16:40:50 GMT header: Server: ESF header: Cache-Control: private header: X-XSS-Protection: 0 header: X-Frame-Options: SAMEORIGIN header: X-Content-Type-Options: nosniff header: Alt-Svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000,h3-Q050=":443"; ma=2592000,h3-Q046=":443"; ma=2592000,h3-Q043=":443"; ma=2592000,quic=":443"; ma=2592000; v="46,43" header: Transfer-Encoding: chunked {'type': 'USER', 'name': 'groups/01fob9te3coo820/memberships/100494212331014619275', 'createTime': '2020-12-20T21:27:19.524955Z', 'updateTime': '2020-12-20T21:27:19.524955Z', 'role': 'OWNER'}

-- @. @.>

On Dec 9, 2021, at 7:19 AM, Jay Lee @. @.>> wrote:

Also worth noting, I believe most of the features have hit v1 so if possible we should switch to v1.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jay0lee/GAM/issues/1262#issuecomment-989949840, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCTYLZWB4KTYJ7X7X36NHDUQDCJDANCNFSM4SKFMTHQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

taers232c commented 2 years ago

Jay,

v1 doesn't have groups.getSecuritySettings and groups.setSecuritySettings

Ross

@.***

On Dec 9, 2021, at 7:19 AM, Jay Lee @.***> wrote:

Also worth noting, I believe most of the features have hit v1 so if possible we should switch to v1.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jay0lee/GAM/issues/1262#issuecomment-989949840, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCTYLZWB4KTYJ7X7X36NHDUQDCJDANCNFSM4SKFMTHQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

jay0lee commented 2 years ago

$ curl -s 'https://cloudidentity.googleapis.com/$discovery/rest?version=v1' | grep SecuritySettings
    "SecuritySettings": {
      "id": "SecuritySettings",
        "updateSecuritySettings": {
            "$ref": "SecuritySettings"
          "id": "cloudidentity.groups.updateSecuritySettings",
        "getSecuritySettings": {
          "id": "cloudidentity.groups.getSecuritySettings",
            "$ref": "SecuritySettings"

it does as far as I can tell...

Jay

taers232c commented 2 years ago

Jay,

Sometime you get the bear, sometimes the bear gets you.

connect: (cloudidentity.googleapis.com, 443) send: b'GET /v1/groups/01gf8i8321qeu55/securitySettings?readMask=%2A&prettyPrint=true&alt=json HTTP/1.1\r\nHost: cloudidentity.googleapis.com\r\naccept: application/json\r\naccept-encoding: gzip, deflate\r\nuser-agent: GAMADV-XTD3 6.11.03 - https://github.com/taers232c/GAMADV-XTD3 / Ross Scroggs @.***> / Python 3.10.1 final / macOS-10.13.6-x86_64-i386-64bit x86_64 / (gzip)\r\nx-goog-api-client: gdcl/2.33.0 gl-python/3.10.1\r\ncontent-length: 0\r\nauthorization: Bearer xxxo\r\n\r\n' reply: 'HTTP/1.1 200 OK\r\n'

send: b'GET /v1/groups/01gf8i8321qeu55/securitySettings?readMask=%2A&prettyPrint=true&alt=json HTTP/1.1\r\nHost: cloudidentity.googleapis.com\r\naccept: application/json\r\naccept-encoding: gzip, deflate\r\nuser-agent: GAMADV-XTD3 6.11.03 - https://github.com/taers232c/GAMADV-XTD3 / Ross Scroggs @.***> / Python 3.10.1 final / macOS-10.13.6-x86_64-i386-64bit x86_64 / (gzip)\r\nx-goog-api-client: gdcl/2.33.0 gl-python/3.10.1\r\ncontent-length: 0\r\nauthorization: Bearer xxxo\r\n\r\n' reply: 'HTTP/1.1 501 Not Implemented\r\n'

I guess this is what they mean by rollong out.

Ross

-- @.***

On Dec 9, 2021, at 12:47 PM, Jay Lee @.***> wrote:

$ curl -s 'https://cloudidentity.googleapis.com/$discovery/rest?version=v1' | grep SecuritySettings "SecuritySettings": { "id": "SecuritySettings", "updateSecuritySettings": { "$ref": "SecuritySettings" "id": "cloudidentity.groups.updateSecuritySettings", "getSecuritySettings": { "id": "cloudidentity.groups.getSecuritySettings", "$ref": "SecuritySettings" it does as far as I can tell...

Jay

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jay0lee/GAM/issues/1262#issuecomment-990237715, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCTYL6OHYCPOT7KXOFYLFLUQEIWPANCNFSM4SKFMTHQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.