Bulk group update throwing error

GAM-team / GAM

command line management for Google Workspace

https://github.com/GAM-team/GAM/wiki

Apache License 2.0

3.54k stars 473 forks source link

Bulk group update throwing error #1623

Open jontatt opened 1 year ago

jontatt commented 1 year ago

The issue tracker is for reporting product deficiencies. "How do I?" questions should be posted to the discussion forum at https://groups.google.com/group/google-apps-manager. When in doubt, start at the discussion forum and return here only when instructed to do so.

Please confirm the following:

I have upgraded to the latest GAM release from https://github.com/GAM-team/GAM/releases and I still have this issue.
I am typing the command as described in the GAM Wiki at https://github.com/jay0lee/gam/wiki

Full steps to reproduce the issue:

gam csv adminsecgroups.csv gam update group “~email” show_in_group_directory false

Expected outcome (what are you trying to do?): hide groups in my csv from our directory

Actual outcome (what errors or bad behavior do you see instead?): I am receiving Group: “~email”@salesforce.com, Update Failed: Missing/Invalid attribute value: id

taers232c commented 1 year ago

Your command has smart/curly quotes: gam csv adminsecgroups.csv gam update group “~email” show_in_group_directory false Replace them with straight quotes: gam csv adminsecgroups.csv gam update group "~email" show_in_group_directory false Smart/curly quotes are not recognized.

Ross

Ross Scroggs @.***

On Apr 21, 2023, at 7:23 PM, jontatt @.***> wrote:

The issue tracker is for reporting product deficiencies. "How do I?" questions should be posted to the discussion forum at https://groups.google.com/group/google-apps-manager https://groups.google.com/group/google-apps-manager. When in doubt, start at the discussion forum and return here only when instructed to do so.

Please confirm the following:

I have upgraded to the latest GAM release from https://github.com/GAM-team/GAM/releases https://github.com/GAM-team/GAM/releases and I still have this issue. I am typing the command as described in the GAM Wiki at https://github.com/jay0lee/gam/wiki https://github.com/jay0lee/gam/wiki Full steps to reproduce the issue:

gam csv adminsecgroups.csv gam update group “~email” show_in_group_directory false

Expected outcome (what are you trying to do?): hide groups in my csv from our directory

Actual outcome (what errors or bad behavior do you see instead?): I am receiving Group: @.***, Update Failed: Missing/Invalid attribute value: id

— Reply to this email directly, view it on GitHub https://github.com/GAM-team/GAM/issues/1623, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCTYL2FGOIQAD7ASN6OAJDXCM6LFANCNFSM6AAAAAAXHQQXKI. You are receiving this because you are subscribed to this thread.

jay0lee commented 1 year ago

Ross, I wonder if we could detect smart quotes anywhere on the gam command and just throw an error with details to fix?

On Sat, Apr 22, 2023, 8:57 AM Ross Scroggs @.***> wrote:

Your command has smart/curly quotes: gam csv adminsecgroups.csv gam update group “~email” show_in_group_directory false Replace them with straight quotes: gam csv adminsecgroups.csv gam update group "~email" show_in_group_directory false Smart/curly quotes are not recognized.

Ross

Ross Scroggs @.***

On Apr 21, 2023, at 7:23 PM, jontatt @.***> wrote:

The issue tracker is for reporting product deficiencies. "How do I?" questions should be posted to the discussion forum at https://groups.google.com/group/google-apps-manager < https://groups.google.com/group/google-apps-manager>. When in doubt, start at the discussion forum and return here only when instructed to do so.

Please confirm the following:

I have upgraded to the latest GAM release from https://github.com/GAM-team/GAM/releases < https://github.com/GAM-team/GAM/releases> and I still have this issue. I am typing the command as described in the GAM Wiki at https://github.com/jay0lee/gam/wiki https://github.com/jay0lee/gam/wiki Full steps to reproduce the issue:

gam csv adminsecgroups.csv gam update group “~email” show_in_group_directory false

Expected outcome (what are you trying to do?): hide groups in my csv from our directory

Actual outcome (what errors or bad behavior do you see instead?): I am receiving Group: @.***, Update Failed: Missing/Invalid attribute value: id

— Reply to this email directly, view it on GitHub < https://github.com/GAM-team/GAM/issues/1623>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACCTYL2FGOIQAD7ASN6OAJDXCM6LFANCNFSM6AAAAAAXHQQXKI . You are receiving this because you are subscribed to this thread.

— Reply to this email directly, view it on GitHub https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518645855, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDIZMFPF6GDPGZG7QDGZALXCPIVBANCNFSM6AAAAAAXHQQXKI . You are receiving this because you were assigned.Message ID: @.***>

taers232c commented 1 year ago

Jay,

GAM could step across the arguments and toss an error if the arg starts with a curly single or double quote. Is it worth the cost?

Ross

Ross Scroggs @.***

On Apr 22, 2023, at 6:03 AM, Jay Lee @.***> wrote:

Ross, I wonder if we could detect smart quotes anywhere on the gam command and just throw an error with details to fix?

On Sat, Apr 22, 2023, 8:57 AM Ross Scroggs @.***> wrote:

Your command has smart/curly quotes: gam csv adminsecgroups.csv gam update group “~email” show_in_group_directory false Replace them with straight quotes: gam csv adminsecgroups.csv gam update group "~email" show_in_group_directory false Smart/curly quotes are not recognized.

Ross

Ross Scroggs @.***

On Apr 21, 2023, at 7:23 PM, jontatt @.***> wrote:

The issue tracker is for reporting product deficiencies. "How do I?" questions should be posted to the discussion forum at https://groups.google.com/group/google-apps-manager < https://groups.google.com/group/google-apps-manager>. When in doubt, start at the discussion forum and return here only when instructed to do so.

Please confirm the following:

I have upgraded to the latest GAM release from https://github.com/GAM-team/GAM/releases < https://github.com/GAM-team/GAM/releases> and I still have this issue. I am typing the command as described in the GAM Wiki at https://github.com/jay0lee/gam/wiki https://github.com/jay0lee/gam/wiki Full steps to reproduce the issue:

gam csv adminsecgroups.csv gam update group “~email” show_in_group_directory false

Expected outcome (what are you trying to do?): hide groups in my csv from our directory

Actual outcome (what errors or bad behavior do you see instead?): I am receiving Group: @.***, Update Failed: Missing/Invalid attribute value: id

— Reply to this email directly, view it on GitHub < https://github.com/GAM-team/GAM/issues/1623>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACCTYL2FGOIQAD7ASN6OAJDXCM6LFANCNFSM6AAAAAAXHQQXKI . You are receiving this because you are subscribed to this thread.

— Reply to this email directly, view it on GitHub https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518645855, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDIZMFPF6GDPGZG7QDGZALXCPIVBANCNFSM6AAAAAAXHQQXKI . You are receiving this because you were assigned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518649885, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCTYL5KLHQICHOBOGYZ2Y3XCPJJLANCNFSM6AAAAAAXHQQXKI. You are receiving this because you commented.

jay0lee commented 1 year ago

I'd go so far as to say smart quotes don't belong in any part of a gam command. I suppose they could be used in a description string but it's rare they are on purpose and seems unlikely they'd be expected to be preserved.

Performance -wise I think it's be pretty quick. I'm split between throwing an error (clean up your data) or just replacing with non smart quotes on the fly. But I do think it'd be a better, more informed user experience than GAM's current naive handling.

Jay

On Sat, Apr 22, 2023, 9:08 AM Ross Scroggs @.***> wrote:

Jay,

GAM could step across the arguments and toss an error if the arg starts with a curly single or double quote. Is it worth the cost?

Ross

Ross Scroggs @.***

On Apr 22, 2023, at 6:03 AM, Jay Lee @.***> wrote:

Ross, I wonder if we could detect smart quotes anywhere on the gam command and just throw an error with details to fix?

On Sat, Apr 22, 2023, 8:57 AM Ross Scroggs @.***> wrote:

Your command has smart/curly quotes: gam csv adminsecgroups.csv gam update group “~email” show_in_group_directory false Replace them with straight quotes: gam csv adminsecgroups.csv gam update group "~email" show_in_group_directory false Smart/curly quotes are not recognized.

Ross

Ross Scroggs @.***

On Apr 21, 2023, at 7:23 PM, jontatt @.***> wrote:

The issue tracker is for reporting product deficiencies. "How do I?" questions should be posted to the discussion forum at https://groups.google.com/group/google-apps-manager < https://groups.google.com/group/google-apps-manager>. When in doubt, start at the discussion forum and return here only when instructed to do so.

Please confirm the following:

I have upgraded to the latest GAM release from https://github.com/GAM-team/GAM/releases < https://github.com/GAM-team/GAM/releases> and I still have this issue. I am typing the command as described in the GAM Wiki at https://github.com/jay0lee/gam/wiki < https://github.com/jay0lee/gam/wiki> Full steps to reproduce the issue:

gam csv adminsecgroups.csv gam update group “~email” show_in_group_directory false

Expected outcome (what are you trying to do?): hide groups in my csv from our directory

Actual outcome (what errors or bad behavior do you see instead?): I am receiving Group: @.***, Update Failed: Missing/Invalid attribute value: id

— Reply to this email directly, view it on GitHub < https://github.com/GAM-team/GAM/issues/1623>, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ACCTYL2FGOIQAD7ASN6OAJDXCM6LFANCNFSM6AAAAAAXHQQXKI

. You are receiving this because you are subscribed to this thread.

— Reply to this email directly, view it on GitHub https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518645855, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABDIZMFPF6GDPGZG7QDGZALXCPIVBANCNFSM6AAAAAAXHQQXKI

. You are receiving this because you were assigned.Message ID: @.***>

— Reply to this email directly, view it on GitHub < https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518649885>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACCTYL5KLHQICHOBOGYZ2Y3XCPJJLANCNFSM6AAAAAAXHQQXKI . You are receiving this because you commented.

— Reply to this email directly, view it on GitHub https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518653906, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDIZMAZ35TDZASTQDUFGPLXCPJ6LANCNFSM6AAAAAAXHQQXKI . You are receiving this because you were assigned.Message ID: @.***>

taers232c commented 1 year ago

Jay,

I've thought about trying to clean up the command but because the parsing is all messed up, I'd just throw an error.

Ross

Ross Scroggs @.***

On Apr 22, 2023, at 6:16 AM, Jay Lee @.***> wrote:

I'd go so far as to say smart quotes don't belong in any part of a gam command. I suppose they could be used in a description string but it's rare they are on purpose and seems unlikely they'd be expected to be preserved.

Performance -wise I think it's be pretty quick. I'm split between throwing an error (clean up your data) or just replacing with non smart quotes on the fly. But I do think it'd be a better, more informed user experience than GAM's current naive handling.

Jay

On Sat, Apr 22, 2023, 9:08 AM Ross Scroggs @.***> wrote:

Jay,

GAM could step across the arguments and toss an error if the arg starts with a curly single or double quote. Is it worth the cost?

Ross

Ross Scroggs @.***

On Apr 22, 2023, at 6:03 AM, Jay Lee @.***> wrote:

Ross, I wonder if we could detect smart quotes anywhere on the gam command and just throw an error with details to fix?

On Sat, Apr 22, 2023, 8:57 AM Ross Scroggs @.***> wrote:

Your command has smart/curly quotes: gam csv adminsecgroups.csv gam update group “~email” show_in_group_directory false Replace them with straight quotes: gam csv adminsecgroups.csv gam update group "~email" show_in_group_directory false Smart/curly quotes are not recognized.

Ross

Ross Scroggs @.***

On Apr 21, 2023, at 7:23 PM, jontatt @.***> wrote:

The issue tracker is for reporting product deficiencies. "How do I?" questions should be posted to the discussion forum at https://groups.google.com/group/google-apps-manager < https://groups.google.com/group/google-apps-manager>. When in doubt, start at the discussion forum and return here only when instructed to do so.

Please confirm the following:

I have upgraded to the latest GAM release from https://github.com/GAM-team/GAM/releases < https://github.com/GAM-team/GAM/releases> and I still have this issue. I am typing the command as described in the GAM Wiki at https://github.com/jay0lee/gam/wiki < https://github.com/jay0lee/gam/wiki> Full steps to reproduce the issue:

gam csv adminsecgroups.csv gam update group “~email” show_in_group_directory false

Expected outcome (what are you trying to do?): hide groups in my csv from our directory

Actual outcome (what errors or bad behavior do you see instead?): I am receiving Group: @.***, Update Failed: Missing/Invalid attribute value: id

— Reply to this email directly, view it on GitHub < https://github.com/GAM-team/GAM/issues/1623>, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ACCTYL2FGOIQAD7ASN6OAJDXCM6LFANCNFSM6AAAAAAXHQQXKI

. You are receiving this because you are subscribed to this thread.

— Reply to this email directly, view it on GitHub https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518645855, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABDIZMFPF6GDPGZG7QDGZALXCPIVBANCNFSM6AAAAAAXHQQXKI

. You are receiving this because you were assigned.Message ID: @.***>

— Reply to this email directly, view it on GitHub < https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518649885>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACCTYL5KLHQICHOBOGYZ2Y3XCPJJLANCNFSM6AAAAAAXHQQXKI . You are receiving this because you commented.

— Reply to this email directly, view it on GitHub https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518653906, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDIZMAZ35TDZASTQDUFGPLXCPJ6LANCNFSM6AAAAAAXHQQXKI . You are receiving this because you were assigned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518655391, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCTYL6TGL3QVRTGYC55FT3XCPK4DANCNFSM6AAAAAAXHQQXKI. You are receiving this because you commented.

jay0lee commented 1 year ago

Ok, then let's just throw an error if smart quotes are anywhere in the command with a helpful explanation of what to look for to fix the command.

Jay

On Sat, Apr 22, 2023, 9:58 AM Ross Scroggs @.***> wrote:

Jay,

I've thought about trying to clean up the command but because the parsing is all messed up, I'd just throw an error.

Ross

Ross Scroggs @.***

On Apr 22, 2023, at 6:16 AM, Jay Lee @.***> wrote:

I'd go so far as to say smart quotes don't belong in any part of a gam command. I suppose they could be used in a description string but it's rare they are on purpose and seems unlikely they'd be expected to be preserved.

Performance -wise I think it's be pretty quick. I'm split between throwing an error (clean up your data) or just replacing with non smart quotes on the fly. But I do think it'd be a better, more informed user experience than GAM's current naive handling.

Jay

On Sat, Apr 22, 2023, 9:08 AM Ross Scroggs @.***> wrote:

Jay,

GAM could step across the arguments and toss an error if the arg starts with a curly single or double quote. Is it worth the cost?

Ross

Ross Scroggs @.***

On Apr 22, 2023, at 6:03 AM, Jay Lee @.***> wrote:

Ross, I wonder if we could detect smart quotes anywhere on the gam command and just throw an error with details to fix?

On Sat, Apr 22, 2023, 8:57 AM Ross Scroggs @.***> wrote:

Your command has smart/curly quotes: gam csv adminsecgroups.csv gam update group “~email” show_in_group_directory false Replace them with straight quotes: gam csv adminsecgroups.csv gam update group "~email" show_in_group_directory false Smart/curly quotes are not recognized.

Ross

Ross Scroggs @.***

On Apr 21, 2023, at 7:23 PM, jontatt @.***> wrote:

The issue tracker is for reporting product deficiencies. "How do I?" questions should be posted to the discussion forum at https://groups.google.com/group/google-apps-manager < https://groups.google.com/group/google-apps-manager>. When in doubt, start at the discussion forum and return here only when instructed to do so.

Please confirm the following:

I have upgraded to the latest GAM release from https://github.com/GAM-team/GAM/releases < https://github.com/GAM-team/GAM/releases> and I still have this issue. I am typing the command as described in the GAM Wiki at https://github.com/jay0lee/gam/wiki < https://github.com/jay0lee/gam/wiki> Full steps to reproduce the issue:

gam csv adminsecgroups.csv gam update group “~email” show_in_group_directory false

Expected outcome (what are you trying to do?): hide groups in my csv from our directory

Actual outcome (what errors or bad behavior do you see instead?): I am receiving Group: @.***, Update Failed: Missing/Invalid attribute value: id

— Reply to this email directly, view it on GitHub < https://github.com/GAM-team/GAM/issues/1623>, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ACCTYL2FGOIQAD7ASN6OAJDXCM6LFANCNFSM6AAAAAAXHQQXKI

. You are receiving this because you are subscribed to this thread.

— Reply to this email directly, view it on GitHub < https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518645855>, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ABDIZMFPF6GDPGZG7QDGZALXCPIVBANCNFSM6AAAAAAXHQQXKI

. You are receiving this because you were assigned.Message ID: @.***>

— Reply to this email directly, view it on GitHub < https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518649885>, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ACCTYL5KLHQICHOBOGYZ2Y3XCPJJLANCNFSM6AAAAAAXHQQXKI

. You are receiving this because you commented.

— Reply to this email directly, view it on GitHub https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518653906, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABDIZMAZ35TDZASTQDUFGPLXCPJ6LANCNFSM6AAAAAAXHQQXKI

. You are receiving this because you were assigned.Message ID: @.***>

— Reply to this email directly, view it on GitHub < https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518655391>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACCTYL6TGL3QVRTGYC55FT3XCPK4DANCNFSM6AAAAAAXHQQXKI . You are receiving this because you commented.

— Reply to this email directly, view it on GitHub https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518666499, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDIZMA6NMQ22LRE7D2JD5LXCPPZHANCNFSM6AAAAAAXHQQXKI . You are receiving this because you were assigned.Message ID: @.***>

taers232c commented 1 year ago

Left single curly quote: Latin-1 \x91 MacOS \xd2 UTF-8 \x20\x18 Right double curly quote: Latin-1 \x93 MacOS \xd4 UTF-8 \x20\x1c

Ross Scroggs @.***

On Apr 22, 2023, at 7:03 AM, Jay Lee @.***> wrote:

Ok, then let's just throw an error if smart quotes are anywhere in the command with a helpful explanation of what to look for to fix the command.

Jay

On Sat, Apr 22, 2023, 9:58 AM Ross Scroggs @.***> wrote:

Jay,

I've thought about trying to clean up the command but because the parsing is all messed up, I'd just throw an error.

Ross

Ross Scroggs @.***

On Apr 22, 2023, at 6:16 AM, Jay Lee @.***> wrote:

I'd go so far as to say smart quotes don't belong in any part of a gam command. I suppose they could be used in a description string but it's rare they are on purpose and seems unlikely they'd be expected to be preserved.

Performance -wise I think it's be pretty quick. I'm split between throwing an error (clean up your data) or just replacing with non smart quotes on the fly. But I do think it'd be a better, more informed user experience than GAM's current naive handling.

Jay

On Sat, Apr 22, 2023, 9:08 AM Ross Scroggs @.***> wrote:

Jay,

GAM could step across the arguments and toss an error if the arg starts with a curly single or double quote. Is it worth the cost?

Ross

Ross Scroggs @.***

On Apr 22, 2023, at 6:03 AM, Jay Lee @.***> wrote:

Ross, I wonder if we could detect smart quotes anywhere on the gam command and just throw an error with details to fix?

On Sat, Apr 22, 2023, 8:57 AM Ross Scroggs @.***> wrote:

Your command has smart/curly quotes: gam csv adminsecgroups.csv gam update group “~email” show_in_group_directory false Replace them with straight quotes: gam csv adminsecgroups.csv gam update group "~email" show_in_group_directory false Smart/curly quotes are not recognized.

Ross

Ross Scroggs @.***

On Apr 21, 2023, at 7:23 PM, jontatt @.***> wrote:

The issue tracker is for reporting product deficiencies. "How do I?" questions should be posted to the discussion forum at https://groups.google.com/group/google-apps-manager < https://groups.google.com/group/google-apps-manager>. When in doubt, start at the discussion forum and return here only when instructed to do so.

Please confirm the following:

I have upgraded to the latest GAM release from https://github.com/GAM-team/GAM/releases < https://github.com/GAM-team/GAM/releases> and I still have this issue. I am typing the command as described in the GAM Wiki at https://github.com/jay0lee/gam/wiki < https://github.com/jay0lee/gam/wiki> Full steps to reproduce the issue:

gam csv adminsecgroups.csv gam update group “~email” show_in_group_directory false

Expected outcome (what are you trying to do?): hide groups in my csv from our directory

Actual outcome (what errors or bad behavior do you see instead?): I am receiving Group: @.***, Update Failed: Missing/Invalid attribute value: id

— Reply to this email directly, view it on GitHub < https://github.com/GAM-team/GAM/issues/1623>, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ACCTYL2FGOIQAD7ASN6OAJDXCM6LFANCNFSM6AAAAAAXHQQXKI

. You are receiving this because you are subscribed to this thread.

— Reply to this email directly, view it on GitHub < https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518645855>, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ABDIZMFPF6GDPGZG7QDGZALXCPIVBANCNFSM6AAAAAAXHQQXKI

. You are receiving this because you were assigned.Message ID: @.***>

— Reply to this email directly, view it on GitHub < https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518649885>, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ACCTYL5KLHQICHOBOGYZ2Y3XCPJJLANCNFSM6AAAAAAXHQQXKI

. You are receiving this because you commented.

— Reply to this email directly, view it on GitHub https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518653906, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABDIZMAZ35TDZASTQDUFGPLXCPJ6LANCNFSM6AAAAAAXHQQXKI

. You are receiving this because you were assigned.Message ID: @.***>

— Reply to this email directly, view it on GitHub < https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518655391>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACCTYL6TGL3QVRTGYC55FT3XCPK4DANCNFSM6AAAAAAXHQQXKI . You are receiving this because you commented.

— Reply to this email directly, view it on GitHub https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518666499, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDIZMA6NMQ22LRE7D2JD5LXCPPZHANCNFSM6AAAAAAXHQQXKI . You are receiving this because you were assigned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518667456, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCTYL3P3UKRUDS24G6V5CLXCPQLDANCNFSM6AAAAAAXHQQXKI. You are receiving this because you commented.

taers232c commented 1 year ago

Correction: Left single curly quote: Latin-1 \x91 MacOS \xd2 Unicode \x2018 UTF-8 \xE2\x80\x98 Right double curly quote: Latin-1 \x93 MacOS \xd4 Unicode \x201c UTF-8 \xE2\x80\x9C

Ross Scroggs @.***

On Apr 22, 2023, at 7:34 AM, Ross Scroggs @.***> wrote:

Left single curly quote: Latin-1 \x91 MacOS \xd2 UTF-8 \x20\x18 Right double curly quote: Latin-1 \x93 MacOS \xd4 UTF-8 \x20\x1c

Ross Scroggs @. @.>

On Apr 22, 2023, at 7:03 AM, Jay Lee @. @.>> wrote:

Ok, then let's just throw an error if smart quotes are anywhere in the command with a helpful explanation of what to look for to fix the command.

Jay

On Sat, Apr 22, 2023, 9:58 AM Ross Scroggs @.***> wrote:

Jay,

I've thought about trying to clean up the command but because the parsing is all messed up, I'd just throw an error.

Ross

Ross Scroggs @.***

On Apr 22, 2023, at 6:16 AM, Jay Lee @.***> wrote:

I'd go so far as to say smart quotes don't belong in any part of a gam command. I suppose they could be used in a description string but it's rare they are on purpose and seems unlikely they'd be expected to be preserved.

Performance -wise I think it's be pretty quick. I'm split between throwing an error (clean up your data) or just replacing with non smart quotes on the fly. But I do think it'd be a better, more informed user experience than GAM's current naive handling.

Jay

On Sat, Apr 22, 2023, 9:08 AM Ross Scroggs @.***> wrote:

Jay,

GAM could step across the arguments and toss an error if the arg starts with a curly single or double quote. Is it worth the cost?

Ross

Ross Scroggs @.***

On Apr 22, 2023, at 6:03 AM, Jay Lee @.***> wrote:

Ross, I wonder if we could detect smart quotes anywhere on the gam command and just throw an error with details to fix?

On Sat, Apr 22, 2023, 8:57 AM Ross Scroggs @.***> wrote:

Your command has smart/curly quotes: gam csv adminsecgroups.csv gam update group “~email” show_in_group_directory false Replace them with straight quotes: gam csv adminsecgroups.csv gam update group "~email" show_in_group_directory false Smart/curly quotes are not recognized.

Ross

Ross Scroggs @.***

On Apr 21, 2023, at 7:23 PM, jontatt @.***> wrote:

The issue tracker is for reporting product deficiencies. "How do I?" questions should be posted to the discussion forum at https://groups.google.com/group/google-apps-manager https://groups.google.com/group/google-apps-manager < https://groups.google.com/group/google-apps-manager https://groups.google.com/group/google-apps-manager>. When in doubt, start at the discussion forum and return here only when instructed to do so.

Please confirm the following:

I have upgraded to the latest GAM release from https://github.com/GAM-team/GAM/releases https://github.com/GAM-team/GAM/releases < https://github.com/GAM-team/GAM/releases https://github.com/GAM-team/GAM/releases> and I still have this issue. I am typing the command as described in the GAM Wiki at https://github.com/jay0lee/gam/wiki https://github.com/jay0lee/gam/wiki < https://github.com/jay0lee/gam/wiki https://github.com/jay0lee/gam/wiki> Full steps to reproduce the issue:

gam csv adminsecgroups.csv gam update group “~email” show_in_group_directory false

Expected outcome (what are you trying to do?): hide groups in my csv from our directory

Actual outcome (what errors or bad behavior do you see instead?): I am receiving Group: @.***, Update Failed: Missing/Invalid attribute value: id

— Reply to this email directly, view it on GitHub < https://github.com/GAM-team/GAM/issues/1623 https://github.com/GAM-team/GAM/issues/1623>, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ACCTYL2FGOIQAD7ASN6OAJDXCM6LFANCNFSM6AAAAAAXHQQXKI https://github.com/notifications/unsubscribe-auth/ACCTYL2FGOIQAD7ASN6OAJDXCM6LFANCNFSM6AAAAAAXHQQXKI

. You are receiving this because you are subscribed to this thread.

— Reply to this email directly, view it on GitHub < https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518645855 https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518645855>, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ABDIZMFPF6GDPGZG7QDGZALXCPIVBANCNFSM6AAAAAAXHQQXKI https://github.com/notifications/unsubscribe-auth/ABDIZMFPF6GDPGZG7QDGZALXCPIVBANCNFSM6AAAAAAXHQQXKI

. You are receiving this because you were assigned.Message ID: @.***>

— Reply to this email directly, view it on GitHub < https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518649885 https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518649885>, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ACCTYL5KLHQICHOBOGYZ2Y3XCPJJLANCNFSM6AAAAAAXHQQXKI https://github.com/notifications/unsubscribe-auth/ACCTYL5KLHQICHOBOGYZ2Y3XCPJJLANCNFSM6AAAAAAXHQQXKI

. You are receiving this because you commented.

— Reply to this email directly, view it on GitHub <https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518653906 https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518653906>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABDIZMAZ35TDZASTQDUFGPLXCPJ6LANCNFSM6AAAAAAXHQQXKI https://github.com/notifications/unsubscribe-auth/ABDIZMAZ35TDZASTQDUFGPLXCPJ6LANCNFSM6AAAAAAXHQQXKI

. You are receiving this because you were assigned.Message ID: @.***>

— Reply to this email directly, view it on GitHub < https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518655391 https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518655391>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACCTYL6TGL3QVRTGYC55FT3XCPK4DANCNFSM6AAAAAAXHQQXKI https://github.com/notifications/unsubscribe-auth/ACCTYL6TGL3QVRTGYC55FT3XCPK4DANCNFSM6AAAAAAXHQQXKI . You are receiving this because you commented.

— Reply to this email directly, view it on GitHub <https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518666499 https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518666499>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDIZMA6NMQ22LRE7D2JD5LXCPPZHANCNFSM6AAAAAAXHQQXKI https://github.com/notifications/unsubscribe-auth/ABDIZMA6NMQ22LRE7D2JD5LXCPPZHANCNFSM6AAAAAAXHQQXKI> . You are receiving this because you were assigned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518667456, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCTYL3P3UKRUDS24G6V5CLXCPQLDANCNFSM6AAAAAAXHQQXKI. You are receiving this because you commented.

jontatt commented 1 year ago

I should have posted back that I solved it, that was the exact problem UGH, gets me every dang time.

Thank you!

Jon Tattersall https://slack.com/app_redirect?channel=WKS4BS5B6[find me on Slack]

Productivity Engineer

C : 857-206-4424

https://smart.salesforce.com/sig/jtattersall//us_mb_kb/default/link.html

On Sat, Apr 22, 2023 at 8:57 AM Ross Scroggs @.***> wrote:

Your command has smart/curly quotes: gam csv adminsecgroups.csv gam update group “~email” show_in_group_directory false Replace them with straight quotes: gam csv adminsecgroups.csv gam update group "~email" show_in_group_directory false Smart/curly quotes are not recognized.

Ross

Ross Scroggs @.***

On Apr 21, 2023, at 7:23 PM, jontatt @.***> wrote:

The issue tracker is for reporting product deficiencies. "How do I?" questions should be posted to the discussion forum at https://groups.google.com/group/google-apps-manager < https://groups.google.com/group/google-apps-manager>. When in doubt, start at the discussion forum and return here only when instructed to do so.

Please confirm the following:

I have upgraded to the latest GAM release from https://github.com/GAM-team/GAM/releases < https://github.com/GAM-team/GAM/releases> and I still have this issue. I am typing the command as described in the GAM Wiki at https://github.com/jay0lee/gam/wiki https://github.com/jay0lee/gam/wiki Full steps to reproduce the issue:

gam csv adminsecgroups.csv gam update group “~email” show_in_group_directory false

Expected outcome (what are you trying to do?): hide groups in my csv from our directory

Actual outcome (what errors or bad behavior do you see instead?): I am receiving Group: @.***, Update Failed: Missing/Invalid attribute value: id

— Reply to this email directly, view it on GitHub < https://github.com/GAM-team/GAM/issues/1623>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACCTYL2FGOIQAD7ASN6OAJDXCM6LFANCNFSM6AAAAAAXHQQXKI . You are receiving this because you are subscribed to this thread.

— Reply to this email directly, view it on GitHub https://github.com/GAM-team/GAM/issues/1623#issuecomment-1518645855, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7LJN7NLFWDFABIEXFILVU3XCPIVBANCNFSM6AAAAAAXHQQXKI . You are receiving this because you authored the thread.Message ID: @.***>

jay0lee commented 1 month ago

@taers232c did we add support for detecting smart quotes and throwing an error at the admin?