search

GAM3RG33K / flutter_settings_screens

Settings Screen with Custom Shared Preference Interface
MIT License
176 stars 71 forks source link

Add keyboardType parameter (type TextInputType) to TextInputSettingsTile. #38

Closed IanDarwin closed 3 years ago

IanDarwin commented 3 years ago

Very convenient to be able to use the keyboard types like name, phone, etc.

IanDarwin commented 3 years ago

Excellent job on this change.

blush It's pretty trivial, but powerful :-)

I have a few changes to request in your contribution:

* remove the default value in both optional parameter & the where the parameter is used, passing the null value is already handled in the Flutter's TextFormField widget

Done, thanks.

* can you change the name of the new parameter to `textInputType`? `keyboardType` is not in-appropriate but is also not consistent. [Optional change]

The reason I called it that is just for consistency with the parameter of the underlying TextField class. I don't feel very strongly either way.