GAM3RG33K / flutter_settings_screens

Settings Screen with Custom Shared Preference Interface
MIT License
176 stars 71 forks source link

Bugfix for ValueChangeObserver.dispose() #93

Closed nyxkn closed 2 years ago

nyxkn commented 2 years ago

We were accidentally deleting the whole _notifier map rather than just the specific cacheKey.

Effect was apparent when dealing with childrenIfEnabled blocks, where upon hiding them, dispose() was being called deleting all the notifiers for all the other keys.

GAM3RG33K commented 2 years ago

Oh, this might be the fix for an issue. Will quote it here soon.

GAM3RG33K commented 2 years ago

This probably fixes the issue #90.