search

GAMPTeam / vampyre

Approximate Message Passing in Python
MIT License
67 stars 27 forks source link

Python2 compatible #1

Closed mborgerding closed 7 years ago

mborgerding commented 7 years ago

I don't know if python2 compatibility is a goal. These changes were needed to work with CentOS 7 linux.

sdrangan commented 7 years ago

Mark,

This is great. Thanks for doing this! Are these in the main branch? I am not that familiar with git. If not, can you merge them in? I think, if compatibility with Python 2.7 is not that difficult, we should do it.

Did you try the test suite on Python 2.7. I only use 3.5, so I never tried 2.7.

Sundeep

On Wed, Jan 11, 2017 at 10:02 AM, mborgerding notifications@github.com wrote:

I don't know if python2 compatibility is a goal. These changes were needed to work with CentOS 7 linux.

You can view, comment on, or merge this pull request online at:

https://github.com/GAMPTeam/vampyre/pull/1 Commit Summary

  • ignore .*.swp files
  • pip --user will install without root privs
  • "python setup.py test" now works if the system python is python2.7
  • converted leading spaces to tabs in Makefile. backslashes confound make, at least on linux.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/GAMPTeam/vampyre/pull/1, or mute the thread https://github.com/notifications/unsubscribe-auth/ANO8I92G_qc-5WkCJGbZkM5STChjdWRjks5rRO7tgaJpZM4LgrXe .

mborgerding commented 7 years ago

I do not currently have push permissions. If you want to add me, see project settings->collaborators

eric-tramel commented 7 years ago

@mborgerding I updated your permissions... I see you've already gotten it integrated, great!