search

GAMPTeam / vampyre

Approximate Message Passing in Python
MIT License
65 stars 28 forks source link

Typo in discrete estim #6

Closed Joshua1989 closed 6 years ago

Joshua1989 commented 7 years ago

I found this when I used a discrete estimator for a complex valued PMF that is symmetric around 0, at the first iteration the estimator initialized the variance to be 0. Actually, there should be an abs in this line https://github.com/GAMPTeam/vampyre/blob/master/vampyre/estim/discrete.py#L65

sdrangan commented 7 years ago

Mengke,

Thanks for pointing this out! I haven't tested any complex cases yet, so I am sure you will find more problems like this. I will correct this.

Sundeep

On Thu, Apr 13, 2017 at 4:20 PM, Mengke Lian notifications@github.com wrote:

I found this when I used a discrete estimator for a complex valued PMF that is symmetric around 0, at the first iteration the estimator initialized the variance to be 0. Actually, there should be an abs in this line https://github.com/GAMPTeam/vampyre/blob/master/vampyre/ estim/discrete.py#L65

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/GAMPTeam/vampyre/issues/6, or mute the thread https://github.com/notifications/unsubscribe-auth/ANO8IyZZXobdUBxaHGM4l158a1qEkrDEks5rvoN1gaJpZM4M9KE6 .

sdrangan commented 6 years ago

This has been corrected