GBKS / bitcoin-wallet-ui-kit

A design system and UI kit for Bitcoin wallet applications.
https://www.bitcoinuikit.com
24 stars 3 forks source link

Update components to use properties #10

Closed stackingsaunter closed 10 months ago

stackingsaunter commented 2 years ago

Hi there!

I propose utilising more properties within the guide, which I guess will affect mostly buttons but can be also in other components like lists or dropdowns, etc. I recorded a quick video about this.

In short, using more properties instead of variants will:

GBKS commented 2 years ago

Already on it, sir. The last version of the UI Kit published on July 29 already has most components updated to use properties. There were a few nice effects like needing much fewer variants for certain components, as showing/hiding could be done via Boolean properties.

stackingsaunter commented 2 years ago

Sweet! I still see a lot of possibilities to improve what I see in that file, I'd be happy to help with these

GBKS commented 2 years ago

Great. Would love to know what you'd change.

stackingsaunter commented 2 years ago

So first of all there is a button component as I laid out in the video. In case we really want to show all possible states of the component we can show them separately like here (I used Propstar plugin to generate that table):

Screenshot 2022-08-12 at 00 16 26

Label component can be done into one (maybe two) highly adjustable components, with each of the element having the possibility to be turned off/on, and adding Copy property

Screenshot 2022-08-12 at 00 19 12

Lot's of those can be merged

Screenshot 2022-08-12 at 00 21 12 Screenshot 2022-08-12 at 00 23 19 Screenshot 2022-08-12 at 00 23 33

Inputs can be expanded into more states (active, filled, focused, error, maybe confirmed (positive feedback)

Screenshot 2022-08-12 at 00 21 52

I see some space for expansion of new elements, like toast messages for example, or other classic UI elements that are missing.

Let me know what you think! I'd happily work on those

GBKS commented 2 years ago

Thanks for this. Some quick responses:

stackingsaunter commented 2 years ago

Another thing is buttons states., there's no hover and focused one. We can add them alongside with field ones

GBKS commented 10 months ago

Going to close this issue as it's gone stale. The states have their separate issue via #18.