search

GBKS / bitcoin-wallet-ui-kit

A design system and UI kit for Bitcoin wallet applications.
https://www.bitcoinuikit.com
24 stars 3 forks source link

Standardize icon structure for consistent color overrides #14

Closed GBKS closed 1 year ago

GBKS commented 1 year ago

When switching an icon instance out, the new icon you pick should maintain the color overrides you added to the previous one. This does not currently happen because the icon layers have different structures, so Figma does not know how to maintain the colors.

Chris researched and the solution appears to be to turn the content of every icon frame into a union an give it the same name.

It may be possible to automate this via a script.

This should be done after #13.

chrislueders commented 1 year ago

This plugin can help us to speed up the process: https://www.figma.com/community/plugin/1196488492656121055/Rename-childs

How to: https://www.youtube.com/watch?v=zddMRhG7tYs

editwentyone commented 1 year ago

is it possible, that this task is already done? I duplicated the file and ran the plugin to rename everything to "Shape" and it worked flawlessly.

another note: I would keep the matrix as one whole source of truth and keep track inside a note on the side, when something was imported.

also separate WIP icons that are not ready yet more clearly and maybe put a dot in front of the name. just some thoughts, maybe it helps a bit

GBKS commented 1 year ago

Sorry, yes, this one is complete. Will close it now.

For documentation purposes, this process was not very smooth, even with plug-ins. Problem is that icons are constructed in so many different ways, and Figma tools for simplifying shapes don't perfectly gel with everything. It required a lot of manual work get this done. However, we don't need to do this often, as the icon set is not getting a ton of updates.