search

GBKS / bitcoin-wallet-ui-kit

A design system and UI kit for Bitcoin wallet applications.
https://www.bitcoinuikit.com
24 stars 3 forks source link

Introduce button states? #18

Open GBKS opened 1 year ago

GBKS commented 1 year ago

We created a whole set of states (hover, active...) for buttons in the Bitcoin Core App (see in Figma here). Do we want to port those over to the UI Kit?

If so, is it maybe time to split the Button into several sub-components to make them easier to manage. We have lots of configurations (3 sizes, 3 styles, 5 states, 4 content variations = 180). There is complexity, the question is just where do we put it.

My initial hunch is to keep components simple (fewer properties) so there's less hidden (less guessing) and less explanation (spec sheets) needed. But let's discuss.

A follow-up discussion would be to document the standard treatments for focus, hover... and which other components would need updating.

GBKS commented 9 months ago

We solved this in the Bitcoin Core App and can just port it from there. Just need to be very careful not to break the 200-300 screen designs when changing over the button.