GBLS / docassemble-MACourts

List Massachusetts Courts in Docassemble
MIT License
5 stars 11 forks source link

Don't case about lower vs upper case when comparing courts #73

Closed BryceStevenWilley closed 10 months ago

BryceStevenWilley commented 10 months ago

From a production error:

  File "/usr/share/docassemble/local3.10/lib/python3.10/site-packages/docassemble/MACourts/macourts.py", line 1024, in courts_from_docket_number
    raise KeyError(f"{court_code} (i.e. {search_court_code}) (from {docket_number}) isn't a valid court code")
KeyError: "h77 (i.e. h77) (from 22h77********) isn't a valid court code"
BryceStevenWilley commented 10 months ago

Noting that I left this open because I still need to test it. I'll try to do that tomorrow.

BryceStevenWilley commented 10 months ago

Got some extra testing in, which I'm glad about because it caught some extra errors.

Specifically requesting your review again @nonprofittechy, because I did make an assumption that docket numbers have to have numbers in them; otherwise anything with the letter P in it gets sent to the Appellate panel court, which didn't seem right (it's certain that confused users might type in sentences to a docket number field if they don't know it, and we shouldn't shunt them to the panel court in that case).

nonprofittechy commented 10 months ago

Got some extra testing in, which I'm glad about because it caught some extra errors.

Specifically requesting your review again @nonprofittechy, because I did make an assumption that docket numbers have to have numbers in them; otherwise anything with the letter P in it gets sent to the Appellate panel court, which didn't seem right (it's certain that confused users might type in sentences to a docket number field if they don't know it, and we shouldn't shunt them to the panel court in that case).

I agree with your decision there.

Is this ready for a full review then?

BryceStevenWilley commented 10 months ago

Is this ready for a full review then?

Yes! I'm happy with where it is now. If you think it's good I'll merge.