search

GBLS / docassemble-MAEvictionDefense

A guided interview for pro se eviction defense in Massachusetts. Generates an Answer form, Request for Discovery, and accompanying forms and motions.
https://www.gbls.org
Other
15 stars 14 forks source link

Testing: Should each language test download its own documents? #156

Closed plocket closed 3 years ago

plocket commented 3 years ago

That is, if the test goes through a scenario in Spanish, should it download a zip file at the end that is separate from the one that was downloaded for the same scenario in English? Or is one zip file per scenario sufficient?

Also, do we think that other da projects out in the world would need these to be separate? Could they have logic in their translated blocks that would affect the creation of their documents? It's at least possible technically I suppose.

plocket commented 3 years ago

What was the answer to this?

nonprofittechy commented 3 years ago

The docs are supposed to be the same

On Sat, May 1, 2021, 9:42 AM plocket @.***> wrote:

What was the answer to this?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/GBLS/docassemble-MAEvictionDefense/issues/156#issuecomment-830635226, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2KTSOQQ6C5BTKDBM2IIX3TLQAM3ANCNFSM4UFFR3UQ .

plocket commented 3 years ago

Would the docs eventually need to be tested separately? [That is, should tests be set up to ensure that every language has the same correct document output.]

plocket commented 3 years ago

On second thought, maybe those options could have some user testing. In practice, maybe those would be good. It would require extra steps from the developer (finding the name of the test and checking the test itself) and I don't think I can guess at the pain point there. Maybe it wouldn't be a pain at all.

nonprofittechy commented 3 years ago

For some theoretical future, sure.

I actually don't think these documents are identical even though they are supposed to be, because they pick up the date formatting from the user's language.

I guess a test could catch that error, although it was not a high priority for me. In some cases, you might have an intentionally different language in the output document. E.g., cover page with instructions.

If you are thinking of adding a feature it could have a theoretical use. It wouldn't be my highest priority one, so that's really you to your discretion.

On Mon, May 3, 2021, 8:47 AM plocket @.***> wrote:

Would the docs eventually need to be tested separately?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/GBLS/docassemble-MAEvictionDefense/issues/156#issuecomment-831236478, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2KTSJFU3NN2R7GRK2ZHCLTL2LN7ANCNFSM4UFFR3UQ .