Should lack of defaults cause test failure?

GBLS / docassemble-MAEvictionDefense

A guided interview for pro se eviction defense in Massachusetts. Generates an Answer form, Request for Discovery, and accompanying forms and motions.

https://www.gbls.org

Other

15 stars 14 forks source link

Should lack of defaults cause test failure? #166

Closed plocket closed 3 years ago

plocket commented 3 years ago

When some languages are missing default answers, should that prompt test failure, or do we just need to adjust the tests to complete all required fields?

nonprofittechy commented 3 years ago

It's not really an important bug, and it takes a lot of work to track down in all the translation files. we'll also need to re-fix that in all of the translation files when we get updated ones in a few weeks. the problem is the translation file offers all mako text for translation, even defaults.

plocket commented 3 years ago

In that case, I'll try to write all tests in the future so that they deliberately fill in the answers that are the default answers. It'll take a little longer, but it'll save on those errors.