GBTAmmoniaSurvey / GAS

observing scripts and files related to the GBT Ammonia Survey (GAS, PI: Jaime E Pineda & Rachel Friesen)
MIT License
6 stars 13 forks source link

include gbtpipe as requirement #198

Open jpinedaf opened 4 years ago

jpinedaf commented 4 years ago

I tried to install GAS from scratch, and I got this error message, related to the gbtpipe.

In [1]: import GAS                                                                                                                                                                                         
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-1-e46441211721> in <module>
----> 1 import GAS

~/science/GAS/build/lib.macosx-10.9-x86_64-3.7/GAS/__init__.py in <module>
     16 if not _ASTROPY_SETUP_:
     17     from . import gasPipeline
---> 18     from . import gridregion
     19     from . import run_grid_regions
     20 #    import rebaseline_multi

~/science/GAS/build/lib.macosx-10.9-x86_64-3.7/GAS/gridregion.py in <module>
     14 import warnings
     15 # import baseline
---> 16 import gbtpipe
     17 from . import __version__
     18 from .utils import VlsrByCoord

ModuleNotFoundError: No module named 'gbtpipe'

The solution should be to now include gbtpipe as part of the setup.py file. However, right now I am still trying to get gbtpipe to install in a MacOSX machine (something related to cfitsio). I will report later.

jpinedaf commented 4 years ago

I installed fitsio and then gbtpipe. Afer this, the installation works

low-sky commented 4 years ago

Hmmm, this requirement has been in place for ~3 years according to https://github.com/GBTAmmoniaSurvey/GAS/commit/08a78607c618b0fb676de8bae0d39ebbb768893e but it's more disturbing that it didn't work. I guess maybe the gbtpipe install failed on a lack of fitsio. The dependency on fitsio is annoying but flows from the gbtpipeline decision.

We don't use much of the pipeline routines for GAS, so I think this should probably allow all the gridding and weather routines (new and improved) without the calibration routines.