search

GBruce82 / Jammming

Jammming Project - Codecademy
0 stars 0 forks source link

onClick Search #14

Open mp1pro opened 6 years ago

mp1pro commented 6 years ago

In searchBar.js we are missing the action to trigger the search like so

<a onClick={this.search}>SEARCH</a>

GBruce82 commented 6 years ago

OH MY GOSH, Marvin. I looked in Atom at my files and this fix is there! So I went to Github and looked at my repository and it's not on the Master. I did a bunch of Troubleshooting (see that branch) and neglected to merge it into master before asking Allyn to have it reviewed. I am so sorry. I'll work my way through the next couple emails you sent but I have a sneaking suspicion that this is going to be the case for all of them. My Jammming project worked GREAT

Greg

From: Marvin Parke notifications@github.com Sent: Wednesday, January 10, 2018 2:52:33 AM To: GBruce82/Jammming Cc: Subscribed Subject: [GBruce82/Jammming] onClick Search (#14)

In searchBar.js we are missing the action to trigger the search like so

SEARCH

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/GBruce82/Jammming/issues/14, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AfJjZ6TV7xntzjervlFsZRMx_wtPFJN0ks5tJJZwgaJpZM4RZIjc.

GBruce82 commented 6 years ago

Shoot. Fat fingers and hit send. My Jammming project worked GREAT from the terminal. I'll look through your other emails and see if I've fixed your concerns by merging the "Troubleshooting" branch with master on Github.

I'm really sorry, Marvin.

Greg

From: Greg - Lynn Bruce glbruce82@outlook.com Sent: Wednesday, January 10, 2018 4:47:08 PM To: GBruce82/Jammming Subject: Re: [GBruce82/Jammming] onClick Search (#14)

OH MY GOSH, Marvin. I looked in Atom at my files and this fix is there! So I went to Github and looked at my repository and it's not on the Master. I did a bunch of Troubleshooting (see that branch) and neglected to merge it into master before asking Allyn to have it reviewed. I am so sorry. I'll work my way through the next couple emails you sent but I have a sneaking suspicion that this is going to be the case for all of them. My Jammming project worked GREAT

Greg

From: Marvin Parke notifications@github.com Sent: Wednesday, January 10, 2018 2:52:33 AM To: GBruce82/Jammming Cc: Subscribed Subject: [GBruce82/Jammming] onClick Search (#14)

In searchBar.js we are missing the action to trigger the search like so

SEARCH

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/GBruce82/Jammming/issues/14, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AfJjZ6TV7xntzjervlFsZRMx_wtPFJN0ks5tJJZwgaJpZM4RZIjc.

mp1pro commented 6 years ago

No Problem, app runs fine now