Advanced Enchantments and Custom Model Data not rendering Armor textures for Armor Sets.

Alphatoxic commented 2 years ago

Describe the bug

To begin, this issue involves the two following plugins: Itemsadder and Advancedenchantments. I have determined that the issue resides within Advanced Enchantments however I am unsure. I am seeking to create armor sets within the AdvancedEnchantments (AE from here on out) plugin. I want to pair these custom armor sets with custom armor textures from Itemsadder (IA from here on out). To begin the diagnosis, I investigated if the issue was with IA. To do this, I looked at the textures of the physical items of the armor. See Figures 1 and 2. Besides the obvious lack of vanilla enchantments on the set from IA in Figure 2, the textures of the items are identical. The issue does not reside within the Custom Model Data itself since the actual textures of the items match from the two plugins. The armor texture is not rendered when they are worn on a player. Figure 3 and 4 is where I am wearing the AE armor with the IA textures (excuse my skin). To show that the armor textures do actually render with IA, see Figures 6 and 7. To identify how this is possible, an understanding on how IA's armor works, so I will provide the WIKI pages regarding armor rendering.

Here is a Link on how to add the armor from IA - https://itemsadder.devs.beer/plugin-usage/advanced/creating-a-custom-item/armor

Here is a Link on how to render the armor in-game from IA - https://itemsadder.devs.beer/plugin-usage/advanced/armors/texture

After understanding how the textures of the IA armor works (I honestly do not fully understand myself), Here is the configurations for both the IA armors, and the asets yml.

IA Druid Armor CONFIG -

info: namespace: druidarmor armors_rendering: druid_armor: color: "#84fc03" layer_1: druid/layer_1 layer_2: druid/layer_2 use_color: false items: druidhelmet: display_name: Floral Wreathe permission: cosmetic_armors.druid_armor resource: generate: true model_id: 88601 textures:

druid/helmet durability: max_custom_durability: 417 specific_properties: armor: slot: head custom_armor: druid_armor attribute_modifiers: head: armor: 3 armorToughness: 3 druidchestplate: display_name: Druid Chestplate permission: cosmetic_armors.druid_armor resource: generate: true model_id: 88602 textures:
druid/chestplate durability: max_custom_durability: 602 specific_properties: armor: slot: chest custom_armor: druid_armor attribute_modifiers: chest: armor: 8 armorToughness: 3 druidleggings: display_name: Druid Leggings permission: cosmetic_armors.druid_armor resource: generate: true model_id: 88603 textures:
druid/leggings durability: max_custom_durability: 565 specific_properties: armor: slot: legs custom_armor: druid_armor attribute_modifiers: legs: armor: 6 armorToughness: 3 druidboots: display_name: Druid Boots permission: cosmetic_armors.druid_armor resource: generate: true model_id: 88604 textures:
druid/boots durability: max_custom_durability: 491 specific_properties: armor: slot: FEET custom_armor: druid_armor attribute_modifiers: feet: armor: 4 armorToughness: 3

AE Armor set CONFIG -

name: '&5&lDruid Armor' material: LEATHER settings: equipped:

'&a&l(!) &aYou have activated the Druid Armor Set!' unequipped:
'&c&l(!) &cYou have deactivated the Druid Armor Set!' items: helmet: name: '&5&lFloral Wreathe'
If you want this item to be a player head, uncomment this line

owner: "name"

Custom Model Data (for 1.13+ servers with custom item packs)

Set custom model data integer

customModelData: 88601

Item Flags

https://hub.spigotmc.org/javadocs/spigot/org/bukkit/inventory/ItemFlag.html

itemFlags: []

- 'HIDE_POTION_EFFECTS' # An Example Item Flag

lore:
- '' enchants: # Supports AdvancedEnchantments CE
- "protection:4"
- "unbreaking:3" chestplate: name: '&2&lDruid Chestplate'
  Custom Model Data (for 1.13+ servers with custom item packs)
  
  Set custom model data integer
  
  customModelData: 88602
  
  Item Flags
  
  https://hub.spigotmc.org/javadocs/spigot/org/bukkit/inventory/ItemFlag.html
  
  itemFlags: []
  
  - 'HIDE_POTION_EFFECTS' # An Example Item Flag
  
  lore:
- '' enchants: # Supports AdvancedEnchantments CE
- "protection:4"
- "unbreaking:3" leggings: name: '&2&lDruid Leggings'
  Custom Model Data (for 1.13+ servers with custom item packs)
  
  Set custom model data integer
  
  customModelData: 88603
  
  Item Flags
  
  https://hub.spigotmc.org/javadocs/spigot/org/bukkit/inventory/ItemFlag.html
  
  itemFlags: []
  
  - 'HIDE_POTION_EFFECTS' # An Example Item Flag
  
  lore:
- '' enchants: # Supports AdvancedEnchantments CE
- "protection:4"
- "unbreaking:3" boots: name: '&2&lDruid Boots'
  Custom Model Data (for 1.13+ servers with custom item packs)
  
  Set custom model data integer
  
  customModelData: 88604
  
  Item Flags
  
  https://hub.spigotmc.org/javadocs/spigot/org/bukkit/inventory/ItemFlag.html
  
  itemFlags: []
  
  - 'HIDE_POTION_EFFECTS' # An Example Item Flag
  
  lore:
- '' enchants: # Supports AdvancedEnchantments CE
- "protection:4"
- "unbreaking:3" events: FALL_DAMAGE: chance: 100 effects:
- 'STOP_ATTACK'

The important places to look can be seen in Figures 7 - 14.

All of the custom model datas match, the armor, when attained via IA, renders when worn, the only issue is when the asets armor is worn.

How to reproduce

Install the latest version of LoneLibs, Itemsadder, AE and its dependencies (if any).
Configure a set of custom armor using the armor renderer from IA.
Match the Custom Model Data into the Asets yml.
Wear the custom armor from AE

Screenshots / Videos

Figure 1 - Items from AE with the IA textures - Figure 2 - Items from IA with the IA textures - Figure 3 - Front of worn Armor from AE with IA textures - Figure 4 - Rear of worn Armor from AE with IA textures - Figure 5 - Front of worn Armor from IA with IA textures - Figure 6 - Rear of worn Armor from IA with IA textures - Figure 7 - Custom Model Data section from Druid Helmet IA CONFIG - Figure 8 - Custom Model Data section from Druid Chestplate IA CONFIG - Figure 9 - Custom Model Data section from Druid Leggings IA CONFIG - Figure 10 - Custom Model Data section from Druid Boots IA CONFIG - Figure 11 - Custom Model Data section from Druid Helmet AE CONFIG - Figure 12 - Custom Model Data section from Druid Chestplate AE CONFIG - Figure 13 - Custom Model Data section from Druid Leggings AE CONFIG - Figure 14 - Custom Model Data section from Druid Boots AE CONFIG -

"/ae plinfo" link

https://paste.md-5.net/peramagehe

Server Log

https://mcpaste.io/e75946dcfdf079bf

DuneSciFye commented 2 years ago

To sum it up, custom model textures made with Item Adder won't display when wearing the armor

Burchard36 commented 2 years ago

Hello, in my past experiences with Armor Models, you need optifine installed on your end in order to render these. Have you tried installing optifine and doing them this way?

I have no experience in ItemsAdder, but I do with CustomItems, and with that plugin you need Optifine installed with armor sets installed to the server side texture pack (And i assume with any other plugin that add custom models to the game for armor)

Have you tried running only ItemsAdder on your server, and validating that they work this way?

Hope to see a response from you :)

DuneSciFye commented 2 years ago

@Burchard36 Close this one, Alpha isn't needing it anymore, I've talked with him

GC-spigot / AdvancedEnchantments