GC-spigot / AdvancedEnchantments

Superior Custom Enchantments Creator for Minecraft And Spigot platform
141 stars 61 forks source link

Guardians still activating despite removing from chestplate #4239

Closed ArmonicPvP closed 1 month ago

ArmonicPvP commented 2 months ago

Describe the bug

Removed Guardians from chestplate (applied with /ae enchant guardians 10, removed with /ae enchant guardians 10) and it still activates, despite being removed from the chestplate

How to reproduce

I have a soul tracker on the chestplate and below is the enchantment that is currently on it (Soulforged) and the enchantment that was on it (Guardians)

guardians: display: '%group-color%Guardians' description: Chance to summon Iron Golems applies-to: Chestplates type: DEFENSE;DEFENSE_MOB;DEFENSE_MOB_PROJECTILE;DEFENSE_PROJECTILE settings: showActionBar: true group: RARE applies:

soulforged: display: '%group-color%Soulforged' description: Chance to collect souls when attacked applies-to: Armor type: DEFENSE;DEFENSE_MOB;DEFENSE_MOB_PROJECTILE;DEFENSE_PROJECTILE group: SOUL applies:

Screenshots / Videos

No response

"/ae plinfo" link

https://paste.md-5.net/imetozurel

Server Log

No response

ArmonicPvP commented 2 months ago

Checking NBT data shows it still exists, re-running the command just says it was removed again. The lore is gone, NBT data is not.

ArmonicPvP commented 2 months ago

Also appears that it activates with it being in my inv, not even wearing. It's in a shulker box and activates.

GC-spigot commented 2 months ago

Also appears that it activates with it being in my inv, not even wearing. It's in a shulker box and activates.

We don't check inside shulker boxes, so that cannot be the case. We switched from NBT to PDC so NBT may still be there, even though the enchant is not on item. We'll look into this.

ThomasWega commented 1 month ago

Try the latest. Works fine for me and the NBT and PDC is removed

ArmonicPvP commented 1 month ago

The initial bug I reported is fixed. I will open up tickets for the other issues I now notice.

ArmonicPvP commented 1 month ago

After further testing, this is still a problem on items which the enchants were removed from before the update. 2024-05-14_16 46 09

ThomasWega commented 1 month ago

Can you please provide the exact way to reproduce this? With the older version - new version. When to remove the item etc.

ArmonicPvP commented 1 month ago

Can you please provide the exact way to reproduce this? With the older version - new version. When to remove the item etc.

this isn't happening anymore after upgrading to 1.20.6 it seems