search

GC-spigot / AdvancedEnchantments

Superior Custom Enchantments Creator for Minecraft And Spigot platform
139 stars 61 forks source link

Anvils do not respect creative mode #4273

Closed Leomelonseeds closed 1 month ago

Leomelonseeds commented 1 month ago

Describe the bug

In vanilla, creative mode users are able to bypass the 40 level limit set on anvil repairs. AdvancedEnchantments seems to have broken this, not allowing creative mode repairs that would cost above 40 levels.

How to reproduce

Simply attempt to enchant a sword too many times in creative mode. A good way to do this is take an enchant such as Sharpness, and apply books with levels 1, 1, 2, 3, 4, 5 in that order, and repeat with other enchants. Eventually, repairs will no longer be possible, even in creative mode.

Screenshots / Videos

Expected behavior (vanilla singleplayer): image

AdvancedEnchantments behavior: image

"/ae plinfo" link

https://paste.md-5.net/apagacukil

Server Log

No response

SirJben commented 1 month ago

First things first, why would you let your survival players get creative mode?

Leomelonseeds commented 1 month ago

I'm not letting survival players get creative mode. I made this issue because I'd like the plugin to have good parity with vanilla. As a server admin, I was testing out anvil combining mechanics, wanting to see among other things how much a repair would cost past the vanilla limit, since I use another popular plugin (AuraSkills) that allows users to bypass that limit. That's where I ran into this issue. I hope you understand.

ThomasWega commented 1 month ago

About the AuraSkills and bypassing the limit, I'll handle that here. https://github.com/GC-spigot/AdvancedEnchantments/issues/4274