search

GC-spigot / AdvancedEnchantments

Superior Custom Enchantments Creator for Minecraft And Spigot platform
138 stars 61 forks source link

Support for pvptoggle plugins. #4317

Closed ClickErrorxD closed 2 weeks ago

ClickErrorxD commented 1 month ago

Describe the bug

PVP Enchantments work on player's when they have pvp toggled off, ultimately, allowing players to kill afk players outside of claims/protection regions, despite the afk player having pvp toggled off from the plugin.

PVP Toggle: https://www.spigotmc.org/resources/togglepvp.44918/

How to reproduce

Use: https://www.spigotmc.org/resources/togglepvp.44918/ Stand outside a claim/protection region, we use griefprevention, so stand outside of it. Activate a pvp-like enchantment, such as Striker on a bow, it'll deal damage.

Screenshots / Videos

No response

"/ae plinfo" link

https://paste.md-5.net/gebowadole

Server Log

https://mcpaste.io/8453916f2194b19a

ThomasWega commented 2 weeks ago

If the other plugin cancels damage events correctly it should work fine