GC-spigot / AdvancedEnchantments

Superior Custom Enchantments Creator for Minecraft And Spigot platform
138 stars 61 forks source link

Grindstone no longer works for enchantment books #4346

Open ArmonicPvP opened 4 weeks ago

ArmonicPvP commented 4 weeks ago

Describe the bug

Grindstone no longer works with custom enchant books

How to reproduce

Use this enchantment and config settings

ravenous:
  display: '%group-color%Ravenous'
  description: Chance to regain hunger while fighting
  applies-to: Swords, Axes
  type: ATTACK;ATTACK_MOB
  group: COMMON
  applies:
    - ALL_SWORD
    - ALL_AXE
  levels:
    '1':
      chance: 3
      cooldown: 2
      effects:
        - ADD_FOOD:<random number>1-3</random number> @Attacker
        - PLAY_SOUND:ENTITY_PLAYER_BURP:1:1
    '2':
      chance: 6
      cooldown: 2
      effects:
        - ADD_FOOD:<random number>1-3</random number> @Attacker
        - PLAY_SOUND:ENTITY_PLAYER_BURP:1:1
    '3':
      chance: 9
      cooldown: 2
      effects:
        - ADD_FOOD:<random number>2-4</random number> @Attacker
        - PLAY_SOUND:ENTITY_PLAYER_BURP:1:1
    '4':
      chance: 12
      cooldown: 2
      effects:
        - ADD_FOOD:<random number>2-4</random number> @Attacker
        - PLAY_SOUND:ENTITY_PLAYER_BURP:1:1
enchantment-book:
  # If true, books can be applied to items in anvils.
  anvil-application: true
  # If true, books can be applied to items by dragging and dropping them on the item in an inventory.
  drag-drop-application: true
  item:
    type: ENCHANTED_BOOK
    id: 0
    custom-model-data: 0
    force-glow: false
  # Variables: %enchant%, %enchant-no-color%, %description%, %level-description%, %applies%, %success%, %destroy%, %color%, %max-level%
  name: ''
  lore:
  - '%group-color%%enchant-no-color% %level%'
settings:
  # If true, right-click triggers will work on off-hand.
  right-click-triggers-on-off-hand: false
  # If true, grindstones will remove custom enchants from items and return a small amount of XP.
  grindstones-remove-custom-enchants: true

Screenshots / Videos

https://github.com/GC-spigot/AdvancedEnchantments/assets/24983808/d2613fff-de3e-4df6-bdf2-a8a927261d19

"/ae plinfo" link

https://paste.md-5.net/ulaxujujoz

Server Log

No response

ThomasWega commented 2 weeks ago

Hey! I've made some changes last version. Can you try on latest AE please?

ArmonicPvP commented 1 week ago

Hey! I've made some changes last version. Can you try on latest AE please?

It is the same still.

ThomasWega commented 1 week ago

https://github.com/GC-spigot/AdvancedEnchantments/assets/82312488/f7d06d5f-6a37-4f48-b13e-518f28ba878a

ArmonicPvP commented 1 week ago

Can you test on 1.20.6? I should've added that I was on 1.20.6. I also don't have any name for the name field on my enchantment book, maybe that is why?

ThomasWega commented 1 week ago

Didn't check the version in plinfo, my bad. 1.20.6 is causing many issues