GC-spigot / AdvancedEnchantments

Superior Custom Enchantments Creator for Minecraft And Spigot platform
154 stars 63 forks source link

Duplication glitch on REPEATING enchants that cost souls #4596

Closed ValhallaCraft closed 5 days ago

ValhallaCraft commented 2 weeks ago

Describe the bug

When a repeating type enchant has a soul cost it is easily duplicated when you right click equip from your hotbar and then scroll.

How to reproduce

Methods to replicate: Have a REPEATING type enchant that costs souls like this one:

glowing:
  display: '{#FF9A8B}G{#FF928B}l{#FF8A8A}o{#FF828A}w{#FF7A89}i{#FF7289}n{#FF6A88}g'
  description: |-
   Gives permanent night vision. (Cost: 1 Soul/5 Seconds)
  applies-to: Helmet
  type: REPEATING
  group: UNIQUE
  applies:
  - ALL_HELMET
  levels:
    '1':
      time: 5
      souls: 1
      effects:
      - POTION:NIGHT_VISION:0:600

Have helmet in hot bar, right click to equip and then scroll. Player must be non-operator so the enchant is actively costing souls.

Screenshots / Videos

https://github.com/user-attachments/assets/8fba1404-8b77-4d12-ae3a-d0ff0d3a9cbb

"/ae plinfo" link

https://paste.md-5.net/usadiyiyez

Server Log

https://mclo.gs/Q3EeG2R

ValhallaCraft commented 2 weeks ago

Also just wanted to add i was able to reproduce this in a solitary environment on latest Purpur 1.21.1 with only AE on the server today as I was trying to rule out it being some type of conflict, confirming it as an AE bug.

ThomasWega commented 5 days ago

Should be fixed in the next update

ValhallaCraft commented 5 days ago

Should be fixed in the next update

Still occurs on latest update.

GC-spigot commented 5 days ago

Read the changelog :) the fix has not yet been released.