search

GC-spigot / AdvancedEnchantments

Superior Custom Enchantments Creator for Minecraft And Spigot platform
153 stars 61 forks source link

Silktouch + veinminer doesn't work correctly #4678

Closed Rexmen1 closed 2 days ago

Rexmen1 commented 1 week ago

Describe the bug

Silktouch + veinmine should only give silked touched items in their pure form but they give ingot form...

How to reproduce

Just have silk touch + vein miner and test?

https://github.com/user-attachments/assets/fb2f9f2b-abfc-4c47-a828-9c977baaa69c

Screenshots / Videos

No response

"/ae plinfo" link

https://paste.md-5.net/eceweledas

Server Log

No response

Confirmation

I Confirm

GC-spigot commented 1 week ago

Glowstone does not work with Veinminer, that is broken by Super Breaker from McMMO as you can see in your action bar: image

Veinminer whitelist: image Glowstone is not in the whitelist.

And the enchantment does correctly work when glowstone is added: https://gyazo.com/c469018c4c8ab9ccd33f3bb2e2ed4c4a

I have no clue why McMMO ignores Silk touch, but my guess is that is how their Super Breaker ability is supposed to work. Try without our vein miner enchantment and you will see the same results. There were actual block drops of glowstone, so it did work as expected, this is just mcmmo messing with other blocks.

I can fix this but it involves messing with mcmmo code and outputs, which is not correct and we should not mess with other plugins. Checking from mcmmo config files: image They only have silk touch for double drops not for superbreaker which is what you used, so I assume that this worked correctly to be honest.

Veinminer definitely did not break any of those blocks.

GC-spigot commented 1 week ago

And update: veinminer does work correctly on other ores as well: https://gyazo.com/39402a1103619b66d2850397e3c6ba09 This is mcmmo.