GC-spigot / battle-pass

The best battle pass plugin on Spigot
52 stars 15 forks source link

Consume Action type don't work #589

Closed ISN-Bulma closed 1 week ago

ISN-Bulma commented 3 weeks ago

Describe the bug

When testing our quests that have the action type consume, it does not give any progress. I have tried several different food types to see if it's the material name that is the issue, but with no luck. And we do not have any plugins that interfere with the eating event in the game.

How to reproduce

This is our quest: '10': name: Week 3 - Healer II type: consume variable: enchanted_golden_apple required-progress: 64 points: 10 item: material: enchanted_golden_apple:0 name: '&6&lHealer II' lore:

But i have also tried:

'10': name: Week 3 - Healer II type: consume variable: cooked_beef:0 required-progress: 64 points: 10 item: material: cooked_beef:0 name: '&6&lHealer II' lore:

Screenshots / Videos

https://gyazo.com/09f2d16f0c426297970caf1c5bdae215

Server Log

No response

KPGTB commented 3 weeks ago

Hey! I can't reproduce your problem. Which version of BattlePass do you use?

Celipa commented 2 weeks ago

Hey! I can't reproduce your problem. Which version of BattlePass do you use?

Newest, i update it everytime and update releases.

KPGTB commented 2 weeks ago

Okay, so instead of using cooked_beef:0, you should use cooked_beef, but enchanted golden apples should work.

ISN-Bulma commented 2 weeks ago

Okay so after updating to newest version cooked_beef now works. I had tried cooked_beef instead ofcooked_beef:0 but it had no change. And when it comes to the apples, it turns out that deluxe combat's custom apple effects were blocking the process. What does the progress track when it comes to golden apples? Does it track the item or the effects it gives the player?

KPGTB commented 1 week ago

Consume action checks "material" name

Celipa commented 1 week ago

Isnt it weird then how it doesnt detect gapples just cause they have other effects? The material stay the same after all :P

KPGTB commented 1 week ago

Maybe author of deluxe combat plugin made something in consume event what causes compatibility issues with our plugin.

I see that the problem with general food has been solved, so I am closing this issue