search

GC-spigot / battle-pass

The best battle pass plugin on Spigot
55 stars 15 forks source link

High timings for placeholder requests #618

Closed leogianfagna closed 2 weeks ago

leogianfagna commented 2 weeks ago

Describe the bug

I know I'm not on latest version (I'm 4.7.9) but the new versions just added new features to the plugin.

Creating placeholderapi quests is causing lag to the server. Here is a spark for it: https://spark.lucko.me/P3S8Ee6WsB

How to reproduce

Create some placeholder quests, like: type: placeholderapi_integer_xltournaments_escavar_score type: placeholderapi_integer_VotingPlugin_Total_Daily_process

It is possible to this high usage for each quest: image

Screenshots / Videos

Above

Server Log

No response

KPGTB commented 2 weeks ago

Hey! Our plugin consumes only 0.5% of server thread so it's not that much. Also I don't see any lags on your spark. Problem which you mentioned is mostly caused by plugin which adds that placeholder (probably mycommands) which executes sql every request, but as I said, 0.5% is not that much and it shouldn't cause any performance problems