search

GCC-Minecraft-Team / sps-mc-link-spigot

Spigot plugin to link SPS and MC accounts
3 stars 1 forks source link

Make certain moderation commands work with SPS names #7

Open nlaha opened 3 years ago

nlaha commented 3 years ago

/op, /kill, /tp should all work with SPS names, trying to find a way to override the function that gets players from their names.

2kai2kai2 commented 3 years ago

Rudimentary solution to just replace SPS usernames with Minecraft usernames when preprocessing non-SPSMC commands. However, this can cause issues when using names as text ("/tell 1khorita You should ask 1njlaha what plugins are running!") rather than a player identifier. Currently only ignoring /me, but we can't really just pick out which commands to ignore since other plugins may introduce them.

nlaha commented 3 years ago

The temporary fix seems good enough for now. Normal players won't interact with those commands that often.