lsmallma
commented
2 years ago Well spotted.
I’ve corrected this in the main_dev_branch for when it gets pushed to the master.
Luke
Dr T. Luke Smallman PDRA (NCEO)
School of GeoSciences Crew Building University of Edinburgh EH9 3JN, UK Edinburgh
On 15 Sep 2022, at 15:29, David Milodowski @.**@.>> wrote:
This email was sent to you by someone outside the University. You should only click on links or attachments if you are certain that the email is genuine and the content is safe.
I think there is a bug in the code translating vpd to relative humidity:
Shouldn't RH = 1 - vpd/vsat ?
I think it's unlikely to directly affect other analyses, as the conversion from rh -> vpd looks ok, and I don't think RH is used directly as input for any of the models
— Reply to this email directly, view it on GitHubhttps://github.com/GCEL/CARDAMOM/issues/21, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGDTODNFWXTHGBDBXHOK3ULV6MXE5ANCNFSM6AAAAAAQNOR3HQ. You are receiving this because you are subscribed to this thread.Message ID: @.***>
The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336. Is e buidheann carthannais a th’ ann an Oilthigh Dhùn Èideann, clàraichte an Alba, àireamh clàraidh SC005336.
I think there is a bug in the code translating vpd to relative humidity:
https://github.com/GCEL/CARDAMOM/blob/9d7a40aa622ecf0c679f5adb2af242b4995ed237/R_functions/convert_between_sp_rh_vpd.r#L46
Shouldn't RH = 1 - vpd/vsat ?
I think it's unlikely to directly affect other analyses, as the conversion from rh -> vpd looks ok, and I don't think RH is used directly as input for any of the models