GCEL / CARDAMOM

The CARbon DAta MOdel FraMework. Computer software that retrieves terrestrial carbon (C) cycle variables by combining C cycle observations with a mass balance model.
GNU General Public License v3.0
2 stars 0 forks source link

Model names #30

Closed DTMilodowski closed 1 year ago

DTMilodowski commented 1 year ago

Hi folks,

Is there a database describing the various model names and their corresponding models? Sorry if I missed this!

Also, which model corresponds to DALEC-ACM2-CDEA-BUCKET?

Thanks!

David

lsmallma commented 1 year ago

There is a model description markdown file on GitHub which has the information you need.

Short name is DALEC.4. long name is in the document.

Sent from Outlook for Androidhttps://aka.ms/AAb9ysg


From: David Milodowski @.> Sent: Monday, 1 May 2023, 15:15 To: GCEL/CARDAMOM @.> Cc: Subscribed @.***> Subject: [GCEL/CARDAMOM] Model names (Issue #30)

This email was sent to you by someone outside the University. You should only click on links or attachments if you are certain that the email is genuine and the content is safe.

Hi folks,

Is there a database describing the various model names and their corresponding models? Sorry if I missed this!

Also, which model corresponds to DALEC-ACM2-CDEA-BUCKET?

Thanks!

David

— Reply to this email directly, view it on GitHubhttps://github.com/GCEL/CARDAMOM/issues/30, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGDTODI4LVQ6HMOCCV472L3XD7AQ5ANCNFSM6AAAAAAXRZ7NZA. You are receiving this because you are subscribed to this thread.Message ID: @.***>

The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336. Is e buidheann carthannais a th’ ann an Oilthigh Dhùn Èideann, clàraichte an Alba, àireamh clàraidh SC005336.

DTMilodowski commented 1 year ago

Ah it was staring right at me in the base CARDAMOM directory Thanks!

DTMilodowski commented 1 year ago

hmmm, windows seems to be modifying the directory names! In linux, everything matches up with the table, so it's not the end of the world (but a bit annoying).

image

Has anyone else found this?

DTMilodowski commented 1 year ago

ok, so the issue is that the directory names end with a "."

Windows doesn't seem to like that very much at all.

Can we change the directory names to make sure that the final "." is removed?

I am going to do this on my branch for now

lsmallma commented 1 year ago

Hi David, we need some sort of end character to ensure names are unique. If not "." we need to pick another delimitator.

Sent from Outlook for Androidhttps://aka.ms/AAb9ysg


From: David Milodowski @.> Sent: Monday, May 1, 2023 3:56:23 PM To: GCEL/CARDAMOM @.> Cc: Luke Smallman @.>; Comment @.> Subject: Re: [GCEL/CARDAMOM] Model names (Issue #30)

This email was sent to you by someone outside the University. You should only click on links or attachments if you are certain that the email is genuine and the content is safe.

ok, so the issue is that the directory names end with a "."

Windows doesn't seem to like that very much at all.

Can we change the directory names to make sure that the final "." is removed?

I am going to do this on my branch for now

— Reply to this email directly, view it on GitHubhttps://github.com/GCEL/CARDAMOM/issues/30#issuecomment-1529797849, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGDTODOTAMDYKO4UQA25B3TXD7FJPANCNFSM6AAAAAAXRZ7NZA. You are receiving this because you commented.Message ID: @.***>

The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336. Is e buidheann carthannais a th’ ann an Oilthigh Dhùn Èideann, clàraichte an Alba, àireamh clàraidh SC005336.

DTMilodowski commented 1 year ago

I am a bit confused, why does the terminal "." ensure unique names? It's only the end "." that is the issue - the other occurrences within the directory name do not cause issues for Windows, so they can be kept as is.

Otherwise, I would switch to an underscore rather than "." as this won't cause a problem. I prefer the "." from an aesthetic perspective though

DTMilodowski commented 1 year ago

DALEC.A1.C1.D2.F2.H2.P1.

would just need to be changed to

DALEC.A1.C1.D2.F2.H2.P1

lsmallma commented 1 year ago

This issue is if searching for a specific model in the code

searching for this string

DALEC.A1.C1.D2.F2.H2.P1

would also select

DALEC.A1.C1.D2.F2.H2.P10

On 01/05/2023 16:36, David Milodowski wrote: This email was sent to you by someone outside the University. You should only click on links or attachments if you are certain that the email is genuine and the content is safe.

DALEC.A1.C1.D2.F2.H2.P1.

would just need to be changed to

DALEC.A1.C1.D2.F2.H2.P1

— Reply to this email directly, view it on GitHubhttps://github.com/GCEL/CARDAMOM/issues/30#issuecomment-1529844548, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGDTODOPJWEVF7QVXNJK2SLXD7KABANCNFSM6AAAAAAXRZ7NZA. You are receiving this because you commented.Message ID: @.***>

-- Dr T. Luke Smallman Research Fellow (NCEO - National Capability)

School of GeoSciences Crew Building University of Edinburgh EH9 3JN, UK Edinburgh

The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336. Is e buidheann carthannais a th’ ann an Oilthigh Dhùn Èideann, clàraichte an Alba, àireamh clàraidh SC005336.

DTMilodowski commented 1 year ago

Is this a search coded up in the software somewhere? I can add string length checks if this is the case, although I can't see anything in the R framework that would pose a particular problem

lsmallma commented 1 year ago

Its more that we currently search for specific model name strings. But in some cases it would be more efficient to make decisions based on the model components, e.g. A1 vs A2. But the only way be can be sure to distinguish between A1 and A10 is for there to be a consistent start and end character i.e. .A1. can never be mistaken for .A10.

To resolve the issue raised either we add an end character to each of the model names which Windows doesn't complain about e.g. # or we replace the . with another character.

Doesn't matter which way we go.

Cheers, Luke

On 02/05/2023 09:49, David Milodowski wrote: This email was sent to you by someone outside the University. You should only click on links or attachments if you are certain that the email is genuine and the content is safe.

Is this a search coded up in the software somewhere? I can add string length checks if this is the case, although I can't see anything in the R framework that would pose a particular problem

— Reply to this email directly, view it on GitHubhttps://github.com/GCEL/CARDAMOM/issues/30#issuecomment-1531102570, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGDTODOHQN7MI2RGYCU3VWTXEDDBNANCNFSM6AAAAAAXRZ7NZA. You are receiving this because you commented.Message ID: @.***>

-- Dr T. Luke Smallman Research Fellow (NCEO - National Capability)

School of GeoSciences Crew Building University of Edinburgh EH9 3JN, UK Edinburgh

The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336. Is e buidheann carthannais a th’ ann an Oilthigh Dhùn Èideann, clàraichte an Alba, àireamh clàraidh SC005336.